Initialize peak controller last sample with base value fix (Stable 1.2) #4699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Should this be merged? |
PhysSong
approved these changes
Jan 15, 2019
Member
PhysSong
left a comment
PhysSong
left a comment
There was a problem hiding this comment.
I'd say let's merge this and address #4382 (comment) later.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PhysSong requested that I make a pull request for this for Stable 1.2 as well, which is probably a good idea. Sorry if making a separate pull request isn't the best way to do this (I'm still learning Github physics), but I'm assuming it's fine.
This is the same fix as #4696, and fixes the bug introduced in #4382.