-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Debian sid build pass #4707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
No objections here. @lukas-w can you please review as well? |
lukas-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make pbuilder use ccache to reduce the build time? https://wiki.ubuntu.com/PbuilderHowto#Integration_with_ccache
|
ccache breaks detecting compile features, so it is not an option yet. |
It turns out the bug is due to the pbuilder bug. It's fixed in the recent version of pbuilder. |
|
I have a WIP branch: https://github.com/PhysSong/lmms/commits/debian-pkg |
|
Your changes look fine. Please merge them into this branch. |
|
@jasp00 I'll clean my changes up and push them into the branch tomorrow. |
|
ccache is enabled. If there are no more issues, I will merge. |
| - ccache -s | ||
| before_deploy: make package | ||
| before_deploy: | ||
| - if [ "$TRAVIS_OS" != debian-sid ]; then make package; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasp00 Isn't this supposed to be $TARGET_OS, or I'm missing something?
* Add Debian sid build pass * Update file locations and copyright * Use ccache * Redirect within sudo * Work around a pbuilder bug which breaks ccache * Debian: enable parallel builds * Travis: Debian: fix caching * Fix shellcheck warnings
This request adds one pass to Travis and updates Debian packaging. The extra time is important but less noticeable because of the parallel osx build. I would like to add another pass for i386 and another one for Clang.