Skip to content

Conversation

@jasp00
Copy link
Member

@jasp00 jasp00 commented Nov 14, 2018

This request adds one pass to Travis and updates Debian packaging. The extra time is important but less noticeable because of the parallel osx build. I would like to add another pass for i386 and another one for Clang.

@tresf
Copy link
Member

tresf commented Nov 21, 2018

No objections here. @lukas-w can you please review as well?

Copy link
Member

@lukas-w lukas-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make pbuilder use ccache to reduce the build time? https://wiki.ubuntu.com/PbuilderHowto#Integration_with_ccache

@jasp00
Copy link
Member Author

jasp00 commented Nov 26, 2018

ccache breaks detecting compile features, so it is not an option yet.

@PhysSong
Copy link
Member

ccache: error: Failed to create directory /var/cache/pbuilder/ccache/f/e: Permission denied

It turns out the bug is due to the pbuilder bug. It's fixed in the recent version of pbuilder.

@PhysSong
Copy link
Member

@jasp00
Copy link
Member Author

jasp00 commented Nov 27, 2018

Your changes look fine. Please merge them into this branch.

@PhysSong
Copy link
Member

@jasp00 I'll clean my changes up and push them into the branch tomorrow.

@jasp00
Copy link
Member Author

jasp00 commented Dec 8, 2018

ccache is enabled. If there are no more issues, I will merge.

@PhysSong
Copy link
Member

PhysSong commented Dec 8, 2018

When I tested on my fork, 80776da seems to make 3cb11db not needed anymore. I also deleted the cache before testing that.

@jasp00
Copy link
Member Author

jasp00 commented Dec 8, 2018

80776da seems to make 3cb11db not needed anymore.

I suspected that, but pbuilder 0.229.1 supports build profiles, which may be useful. Since it works, I would rather keep it.

@jasp00 jasp00 merged commit 698c39d into stable-1.2 Dec 9, 2018
@jasp00 jasp00 deleted the debian-pkg branch December 9, 2018 10:19
- ccache -s
before_deploy: make package
before_deploy:
- if [ "$TRAVIS_OS" != debian-sid ]; then make package; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasp00 Isn't this supposed to be $TARGET_OS, or I'm missing something?

@jasp00 jasp00 mentioned this pull request Jan 7, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Add Debian sid build pass

* Update file locations and copyright

* Use ccache

* Redirect within sudo

* Work around a pbuilder bug which breaks ccache

* Debian: enable parallel builds

* Travis: Debian: fix caching

* Fix shellcheck warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants