Disable built-in NaN handler through hidden setting #4787
Merged
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Are you sure this should be a hidden setting? |
Member
Author
|
Your answer at #4743 (comment). |
Contributor
|
Sorry, I really don't follow you now. |
Member
Author
|
We agreed that this should be a hidden setting. |
Contributor
|
Right. And now I'm suggesting maybe it should not be hidden. I'm totally cool either way. |
Member
Author
|
I prefer the setting to be hidden until a user asks otherwise because the setup dialog and the code are simpler. |
Closed
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Disable built-in NaN handler through hidden setting * Reuse code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable built-in handler for NaN and huge values; this allows the user to control these cases. Default is to use the handler.