Increase Mixer fader falloff speed #5038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a display bug that is present with large fader falloff speeds.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Increase Mixer fader falloff speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some complaints about how LMMS's Mixer faders are inaccurate. This fixes that by drastically increasing the falloff speed. So far, every person I've shown the results to said this is a major improvement.
This PR also fixes a bug in the Mixer fader display which isn't too obvious at first but becomes very obvious when the falloff is increased, which is why more than just one line was changed. If you'd like to see the bug that was present previously, just take the original code and increase the falloff number, you'll see it.
(The bug causes the fader volume to flutter between its real volume and the volume some distance below it (determined by the falloff) every time the code is run.)