Skip to content

Fix stuck keys when dragging on piano view #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonkmachine merged 2 commits into from
Sep 8, 2019
Merged

Fix stuck keys when dragging on piano view #5127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a48e75
Fix stuck keys when dragging on piano view
DomClark Aug 16, 2019
4eb2284
Add comment
DomClark Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/NotePlayHandle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ void NotePlayHandle::play( sampleFrame * _working_buffer )

lock();

if( m_totalFramesPlayed == 0 && !m_hasMidiNote
if( m_totalFramesPlayed == 0 && !m_hasMidiNote && !m_released
&& ( hasParent() || ! m_instrumentTrack->isArpeggioEnabled() ) )
{
m_hasMidiNote = true;
Expand Down