Add close button to SideBarWidget#5133
Merged
PhysSong merged 4 commits intoLMMS:masterfrom Oct 1, 2019
Merged
Conversation
PhysSong
reviewed
Aug 19, 2019
PhysSong
reviewed
Aug 19, 2019
Member
|
The best way I can think of is:
|
Reflexe
added
needs code review
PhysSong
reviewed
Aug 26, 2019
PhysSong
removed
the
needs style review
PhysSong
reviewed
Sep 12, 2019
Downloads for this pull requestGenerated by the LMMS pull requests bot. |
1 similar comment
Downloads for this pull requestGenerated by the LMMS pull requests bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My take on #3682.
I feel like there could be a little more refactoring for finding the button/widget, but this works for now.