Skip to content

Allow playing muted pattern in the piano roll #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhysSong merged 2 commits into from
Aug 21, 2019
Merged

Allow playing muted pattern in the piano roll #5134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f09ed
Allow PianoRoll to play while muted
Veratil Aug 15, 2019
08a117b
Update behavior comment and playMode check
Veratil Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/tracks/InstrumentTrack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,8 +652,11 @@ bool InstrumentTrack::play( const MidiTime & _start, const fpp_t _frames,
for( tcoVector::Iterator it = tcos.begin(); it != tcos.end(); ++it )
{
Pattern* p = dynamic_cast<Pattern*>( *it );
// everything which is not a pattern or muted won't be played
if( p == NULL || ( *it )->isMuted() )
// everything which is not a pattern won't be played
// A pattern playing in the Piano Roll window will always play
if(p == NULL ||
(Engine::getSong()->playMode() != Song::Mode_PlayPattern
&& (*it)->isMuted()))
{
continue;
}
Expand Down