Make splash screen text white, themeable #5149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spekular
commented
Aug 25, 2019
Member
Author
Spekular
left a comment
Spekular
left a comment
There was a problem hiding this comment.
Themeable solution, part 1.
Spekular
changed the title
Member
Author
|
This should probably be squashed into one commit if/when merged. |
Member
|
@Spekular I recommend doing it without code changes if possible... QSplashScreen QLabel {
color: white;
} |
Member
Author
|
Huh. Will fix. |
Member
|
I tested @tresf's solution locally. It seems to work. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Make splash screen text white Closes LMMS#5023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5023