tweak amplitude ranges, update and fix readme.md

plugins/SpectrumAnalyzer/README.md

@@ -6,11 +6,15 @@ This plugin consists of three widgets and back-end code to provide them with req
 
 The top-level widget is SaControlDialog. It populates a configuration widget (created dynamically) and instantiates spectrum display widgets. Its main back-end class is SaControls, which holds all configuration values and globally valid constants (e.g. range definitions).
 
-SaSpectrumDisplay and SaWaterfallDisplay show the result of spectrum analysis. Their main back-end class is SaProcessor, which performs FFT analysis on data received from the Analyzer class, which in turn handles the interface with LMMS.
+SaSpectrumView and SaWaterfallView show the result of spectrum analysis. Their main back-end class is SaProcessor, which performs FFT analysis on data received from the Analyzer class, which in turn handles the interface with LMMS.
 
 
 ## Changelog
 
+	1.0.3	2019-07-25
+		- rename and tweak amplitude ranges based on feedback
+	1.0.2	2019-07-12
+		- variety of small changes based on code review
 	1.0.1	2019-06-02
 		- code style changes
 		- added tool-tips

plugins/SpectrumAnalyzer/SaControls.cpp

@@ -62,10 +62,10 @@ SaControls::SaControls(Analyzer *effect) :
 	m_freqRangeModel.setValue(m_freqRangeModel.findText(tr("Full (auto)")));
 
 	m_ampRangeModel.addItem(tr("Extended"));
-	m_ampRangeModel.addItem(tr("Default"));
 	m_ampRangeModel.addItem(tr("Audible"));
-	m_ampRangeModel.addItem(tr("Noise"));
-	m_ampRangeModel.setValue(m_ampRangeModel.findText(tr("Default")));
+	m_ampRangeModel.addItem(tr("Loud"));
+	m_ampRangeModel.addItem(tr("Silent"));
+	m_ampRangeModel.setValue(m_ampRangeModel.findText(tr("Audible")));
 
 	// FFT block size labels are generated automatically, based on
 	// FFT_BLOCK_SIZES vector defined in fft_helpers.h

plugins/SpectrumAnalyzer/SaControls.h

@@ -59,19 +59,19 @@ const int FRANGE_HIGH_END = 20000;
 enum AMPLITUDE_RANGES
 {
 	ARANGE_EXTENDED = 0,
-	ARANGE_DEFAULT,
 	ARANGE_AUDIBLE,
-	ARANGE_NOISE
+	ARANGE_LOUD,
+	ARANGE_SILENT
 };
 
 const int ARANGE_EXTENDED_START = -80;
 const int ARANGE_EXTENDED_END = 20;
-const int ARANGE_DEFAULT_START = -30;
-const int ARANGE_DEFAULT_END = 0;
 const int ARANGE_AUDIBLE_START = -50;
-const int ARANGE_AUDIBLE_END = 10;
-const int ARANGE_NOISE_START = -60;
-const int ARANGE_NOISE_END = -20;
+const int ARANGE_AUDIBLE_END = 0;
+const int ARANGE_LOUD_START = -30;
+const int ARANGE_LOUD_END = 0;
+const int ARANGE_SILENT_START = -60;
+const int ARANGE_SILENT_END = -10;
 
 
 class Analyzer;

plugins/SpectrumAnalyzer/SaProcessor.cpp

@@ -499,10 +499,10 @@ float SaProcessor::getAmpRangeMin(bool linear) const
 	switch (m_controls->m_ampRangeModel.value())
 	{
 		case ARANGE_EXTENDED: return ARANGE_EXTENDED_START;
-		case ARANGE_AUDIBLE: return ARANGE_AUDIBLE_START;
-		case ARANGE_NOISE: return ARANGE_NOISE_START;
+		case ARANGE_SILENT: return ARANGE_SILENT_START;
+		case ARANGE_LOUD: return ARANGE_LOUD_START;
 		default:
-		case ARANGE_DEFAULT: return ARANGE_DEFAULT_START;
+		case ARANGE_AUDIBLE: return ARANGE_AUDIBLE_START;
 	}
 }
 
@@ -512,10 +512,10 @@ float SaProcessor::getAmpRangeMax() const
 	switch (m_controls->m_ampRangeModel.value())
 	{
 		case ARANGE_EXTENDED: return ARANGE_EXTENDED_END;
-		case ARANGE_AUDIBLE: return ARANGE_AUDIBLE_END;
-		case ARANGE_NOISE: return ARANGE_NOISE_END;
+		case ARANGE_SILENT: return ARANGE_SILENT_END;
+		case ARANGE_LOUD: return ARANGE_LOUD_END;
 		default:
-		case ARANGE_DEFAULT: return ARANGE_DEFAULT_END;
+		case ARANGE_AUDIBLE: return ARANGE_AUDIBLE_END;
 	}
 }