Prevent LMMS VisualizationWidget from showing clipping color at exactly 0 db #5162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostRobotMusic
changed the title
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... I know this looks really dumb and unnecessary, and is probably the most basic PR ever made in the history of mankind, but this is a bugfix.
It's very common for me to be playing a sound that hits exactly 0 db (but doesn't cross 0 db), and when I see the visualizer turn red, I think the sound is clipping. This is especially common when playing an individual sound with lots of distortion applied (many/most types of distortion have a hard limit at exactly 0 db). This PR just changes "<" to "<=" in the code, which is how it should be.
I... feel embarrassed, like I'm breaking a serious rule for making a PR that's so basic. 😆
I'm assuming this can just be merged instantly (well, squash-and-merged, sorry for messy commit history), though I will verify on Discord first.