Skip to content

Support compilation with MSVC 2019 #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DomClark merged 1 commit into from
Sep 10, 2019
Merged

Support compilation with MSVC 2019 #5180

DomClark merged 1 commit into from
Sep 10, 2019

Conversation

@DomClark
Copy link
Member

@DomClark DomClark commented Sep 9, 2019

  • Qt only offers binaries up to MSVC 2017, since MSVC 2019 is binary compatible with 2017. Thus we set MSVC_YEAR to 2017 even for MSVC 2019.
  • The default platform for MSVC 2019 is no longer Win32, but is now that of the host. Thus it is necessary to specify CMAKE_GENERATOR_PLATFORM Win32 in ExternalProject_Add.

Reflexe
Reflexe reviewed Sep 10, 2019
View reviewed changes
@DomClark DomClark removed the request for review from PhysSong September 10, 2019 14:17
@DomClark DomClark merged commit 91cf5bd into LMMS:master Sep 10, 2019
@DomClark DomClark deleted the msvc-2019 branch March 12, 2021 19:05
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@DomClark
Support compilation with MSVC 2019 (LMMS#5180)
2745ffd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhysSong PhysSong PhysSong left review comments

@Reflexe Reflexe Reflexe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DomClark @PhysSong @Reflexe