Fix #3005

[Veratil]

mouseDoubleClickEvent wasn't forwarding to mousePressEvent like the default implementation does. This adds that check.

I don't believe this should cause any problems double clicking elsewhere (I can't seem to find any problems with a basic test), but just in case we can restrict this to just the piano key area.

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.2.0.554-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.2.0.554-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.2.0.554-mingw-win64.exe (build link)

🤖

{"commit_sha": "b416186bc886df9062c9f6a463940b3ac5061213", "platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://4915-15778896-gh.circle-artifacts.com/0/lmms-1.2.0.554-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4915?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://4917-15778896-gh.circle-artifacts.com/0/lmms-1.2.0.554-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4917?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://4918-15778896-gh.circle-artifacts.com/0/lmms-1.2.0.554-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4918?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}}

[PhysSong]

mouseDoubleClickEvent wasn't forwarding to mousePressEvent like the default implementation does.

Then why don't you call the default implementation instead of calling mousePressEvent directly? I understand both give the same result, but this will make it easy to see what it does.

[Veratil]

mouseDoubleClickEvent wasn't forwarding to mousePressEvent like the default implementation does.

Then why don't you call the default implementation instead of calling mousePressEvent directly? I understand both give the same result, but this will make it easy to see what it does.

I don't understand, is this not easy to see what it does?

[zonkmachine]

Tests fine!

[lukas-w]

@PhysSong's suggestion is the standard way of doing this, see https://doc.qt.io/qt-5/eventsandfilters.html#event-handlers for reference. We don't act on the event, so we should let the base class handle it.

[Veratil]

@PhysSong's suggestion is the standard way of doing this, see https://doc.qt.io/qt-5/eventsandfilters.html#event-handlers for reference. We don't act on the event, so we should let the base class handle it.

Ah! I understand now. 😄 Thanks!

[lukas-w]

Merged and cherry-picked to stable-1.2 via a8d91b1.