Skip to content

Conversation

@tecknixia
Copy link
Contributor

@tecknixia tecknixia commented Oct 30, 2019

Related to issue #5225
And replaces old PR #5232

Allows user to place cursor over an automation point in the Automation Editor, and use scroll wheel to adjust the y level for that point. It also improves mouse cursor interaction with the point, and shows the point's Y level when mouse cursor is over a point.

https://cdn.discordapp.com/attachments/332258319228207114/629248936099708928/AutomationEditor2-2019-10-03_04.21.20.mp4 (example, not current)

This PR involves the creation of a variable, and the use of mouseMoveEvent, drawCross, and wheelEvent.

  • A variable, m_pointYLevel is created and used to hold a point's Y level position.
  • The value of m_pointYLevel is set when the mouse moves over a point.
  • The value of m_pointYLevel changes when the mouse wheel is scrolled, and over a point.
  • The point's Y level changes when the mouse wheel is scrolled, and over a point.
  • If the mouse moves away from a point, the value of m_pointYLevel returns to 0.
  • When the value of m_pointYLevel is 0, the tool tip in drawCross displays the Y level position of the mouse.
  • When the value of m_pointYLevel is greater than 0, the tool tip in drawCross displays the point's Y level position.

@LmmsBot
Copy link

LmmsBot commented Oct 30, 2019

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://5089-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5089?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://5088-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5088?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://5086-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5086?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/bliy0lxyg1patpps/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28691763"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/fgkegbgmiu7vaauv/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28691763"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://5087-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5087?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "fedff3ed1bc08ba88b1ef3687060203585258a2f"}

@zonkmachine zonkmachine added needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR needs testing This pull request needs more testing labels Apr 9, 2020
@tecknixia
Copy link
Contributor Author

@russiankumar #5592
Issue with macos, not sure how to resolve.
Double clicking is good enough. ( #5292 )
This PR is not as important. In fact, I just realized that it would be better if the automation point was able to be selected before using the scroll wheel so it doesn't interfere with scrolling on the y-axis.
This PR can be closed.

@ryuukumar
Copy link
Member

Ah, I believe we’ve dropped the overhaul for now. If you need to work on something you can do so, there’s no hurry for now.

@IanCaio
Copy link
Contributor

IanCaio commented Dec 26, 2020

@russiankumar #5592
Issue with macos, not sure how to resolve.
Double clicking is good enough. ( #5292 )
This PR is not as important. In fact, I just realized that it would be better if the automation point was able to be selected before using the scroll wheel so it doesn't interfere with scrolling on the y-axis.
This PR can be closed.

Closing this PR in favor of the other one as suggested by the author!

@IanCaio IanCaio closed this Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR needs testing This pull request needs more testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants