Skip to content

Fix remote plugin crash reading parameters from Grooove plugin #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DomClark merged 2 commits into from
Nov 17, 2019
Merged

Fix remote plugin crash reading parameters from Grooove plugin #5300

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
575f233
Fix Grooove buffer overrun
DomClark Nov 1, 2019
be693b6
Make it even bigger
DomClark Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Grooove buffer overrun
  • Loading branch information
@DomClark
DomClark committed Nov 1, 2019
commit 575f233405df0908d1ad79dd7bd4fe57243ba8d5
2 changes: 1 addition & 1 deletion plugins/vst_base/RemoteVstPlugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@ void RemoteVstPlugin::getParameterDump()

for( int i = 0; i < m_plugin->numParams; ++i )
{
char paramName[32];
char paramName[65];
memset( paramName, 0, sizeof( paramName ) );
pluginDispatch( effGetParamName, i, 0, paramName );
paramName[sizeof(paramName)-1] = 0;
Expand Down