Skip to content

add pause shortcut shift + sapce (#5301) #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tjrdnjs1609 wants to merge 3 commits into from
Closed

add pause shortcut shift + sapce (#5301) #5332

tjrdnjs1609 wants to merge 3 commits into from

Conversation

@tjrdnjs1609
Copy link

@tjrdnjs1609 tjrdnjs1609 commented Dec 1, 2019

add shortcut shift + space for pause on SongEditor.cpp
it only work on playing state.
when it paused, shift + space does not work.

@LmmsBot
Copy link

LmmsBot commented Dec 1, 2019 •
edited
Loading

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

🤖 
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://5541-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.579-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://5540-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.579-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5540?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://5539-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.579-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5539?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/9mr8hg5d4e39j435/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/29749358"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/kdba9axo2ujbgp3h/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/29749358"}]}, "commit_sha": "b0438031054cfde59e83cebf7cf6ac62d28a9671"}

@tjrdnjs1609
Copy link
Author

tjrdnjs1609 commented Dec 9, 2019

i solve #5301 this problem.
anyone review my code??? is less then 10 line...

@PhysSong
Copy link
Member

PhysSong commented Dec 10, 2019

Sorry for the late reply. You'd better look into Editor, the base class of SongEditor. That will make the shortcut available for other editors such as the beat/bassline editor.
Also, Song::togglePause() looks better for pausing the playback.

@tjrdnjs1609
Copy link
Author

tjrdnjs1609 commented Dec 11, 2019

@PhysSong thanks for reply. i'll check again.

@PhysSong
Copy link
Member

PhysSong commented Apr 28, 2020

@tjrdnjs1609 Are you still interested in this? If not, I'm going to close this so anyone else can code fixes for #5301. Otherwise, I can help you finish this stuff.

@PhysSong PhysSong added the response required A response from OP is required or the issue is closed automatically within 14 days. label Apr 28, 2020
@zonkmachine zonkmachine mentioned this pull request May 31, 2020
Closed
11 tasks
ryuukumar
ryuukumar reviewed Jul 2, 2020
View reviewed changes
Copy link
Member

@ryuukumar ryuukumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mentioned this already, but try running git rebase and moving to the latest version of master.

include/lmms_constants.h
Comment on lines -52 to -94
// Frequency ranges (in Hz).
// Arbitrary low limit for logarithmic frequency scale; >1 Hz.
const int LOWEST_LOG_FREQ = 10;

// Full range is defined by LOWEST_LOG_FREQ and current sample rate.
enum FREQUENCY_RANGES
{
FRANGE_FULL = 0,
FRANGE_AUDIBLE,
FRANGE_BASS,
FRANGE_MIDS,
FRANGE_HIGH
};

const int FRANGE_AUDIBLE_START = 20;
const int FRANGE_AUDIBLE_END = 20000;
const int FRANGE_BASS_START = 20;
const int FRANGE_BASS_END = 300;
const int FRANGE_MIDS_START = 200;
const int FRANGE_MIDS_END = 5000;
const int FRANGE_HIGH_START = 4000;
const int FRANGE_HIGH_END = 20000;

// Amplitude ranges (in dBFS).
// Reference: full scale sine wave (-1.0 to 1.0) is 0 dB.
// Doubling or halving the amplitude produces 3 dB difference.
enum AMPLITUDE_RANGES
{
ARANGE_EXTENDED = 0,
ARANGE_AUDIBLE,
ARANGE_LOUD,
ARANGE_SILENT
};

const int ARANGE_EXTENDED_START = -80;
const int ARANGE_EXTENDED_END = 20;
const int ARANGE_AUDIBLE_START = -50;
const int ARANGE_AUDIBLE_END = 0;
const int ARANGE_LOUD_START = -30;
const int ARANGE_LOUD_END = 0;
const int ARANGE_SILENT_START = -60;
const int ARANGE_SILENT_END = -10;

Copy link
Member

@ryuukumar ryuukumar Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh.... why are you removing all this?

plugins/SpectrumAnalyzer/README.md
Comment on lines -20 to -41
1.1.2 2019-11-18
- waterfall is no longer cut short when width limit is reached
- various small tweaks based on final review
1.1.1 2019-10-13
- improved interface for accessing SaProcessor private data
- readme file update
- other small improvements based on reviews
1.1.0 2019-08-29
- advanced config: expose hidden constants to user
- advanced config: add support for FFT window overlapping
- waterfall: display at native resolution on high-DPI screens
- waterfall: add cursor and improve label density
- FFT: fix normalization so that 0 dBFS matches full-scale sinewave
- FFT: decouple data acquisition from processing and display
- FFT: separate lock for reallocation (to avoid some needless waiting)
- moved ranges and other constants to a separate file
- debug: better performance measurements
- various performance optimizations
1.0.3 2019-07-25
- rename and tweak amplitude ranges based on feedback
1.0.2 2019-07-12
- variety of small changes based on code review
Copy link
Member

@ryuukumar ryuukumar Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I get it, I think there were changes made which you haven't updated in your PR. You could rebase to fix these issues.

src/gui/editors/SongEditor.cpp
Comment on lines +526 to +534
else if ( ke->key() == Qt::Key_Space && ke->modifiers() & Qt::ShiftModifier )
{
tick_t t = m_song->currentTick();
if ( t >= 0 && m_song->isPlaying() )
{
m_song->stop();
m_song->setPlayPos( t, Song::Mode_PlaySong );
}
}
Copy link
Member

@ryuukumar ryuukumar Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code is okay. I don't have write access either ways, but I think you should rebase to fix all those other files that are messed up in the PR, and I think you'll be ready for a merge (which I can't do).

@ryuukumar ryuukumar mentioned this pull request Jul 3, 2020
Merged
@PhysSong
Copy link
Member

PhysSong commented Jul 5, 2020

Closed in favor of #5554.

@PhysSong PhysSong closed this Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryuukumar ryuukumar ryuukumar left review comments

Assignees

No one assigned

Labels

response required A response from OP is required or the issue is closed automatically within 14 days.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjrdnjs1609 @LmmsBot @PhysSong @ryuukumar