Skip to content

Fix #5194: Fix knobs moving too fast #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohannesLorenz merged 11 commits into from
May 24, 2020
Merged

Fix #5194: Fix knobs moving too fast #5360

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6022dda
Fixes #5194: Fix knobs moving too fast
JohannesLorenz Dec 30, 2019
b61d867
Make knob increase linear to mouse
JohannesLorenz May 5, 2020
30a3d00
Test that disables setPos everywhere
JohannesLorenz May 10, 2020
9d7f172
Fix factor from .09f to .4f
JohannesLorenz May 11, 2020
2ebf016
Knob: Remove now unused `m_origMousePos`
JohannesLorenz May 14, 2020
f662a33
Fix #5194 also for LcdSpinBox
JohannesLorenz May 14, 2020
c98bb19
LcdSpinBox: Reset factor to 2
JohannesLorenz May 18, 2020
feb1237
Fix `LcdSpinBox` "mouse to value" algorithm
JohannesLorenz May 21, 2020
45f1e86
LcdSpinBox: Recall float offset
JohannesLorenz May 22, 2020
0cda4e8
LcdSpinBox: Improve indentation
JohannesLorenz May 22, 2020
52a8554
LcdSpinBox: Explicit braces
JohannesLorenz May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
LcdSpinBox: Reset factor to 2
  • Loading branch information
@JohannesLorenz
JohannesLorenz committed May 18, 2020
commit c98bb1914dc755f10955c5b55d2370ab47b7b1d9
2 changes: 1 addition & 1 deletion src/gui/widgets/LcdSpinBox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ void LcdSpinBox::mouseMoveEvent( QMouseEvent* event )
{
if( m_mouseMoving )
{
int dy = 3 * (event->globalY() - m_lastMousePos.y());
int dy = 2 * (event->globalY() - m_lastMousePos.y());
if( event->modifiers() & Qt::ShiftModifier )
dy = qBound( -4, dy/4, 4 );
if( dy > 1 || dy < -1 )
Expand Down