STK Mallets: fix noise/freezing on instrument switch #5428
Merged
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes the underlying noise on instrument switches.
zonkmachine
approved these changes
Mar 24, 2020
Contributor
zonkmachine
left a comment
zonkmachine
left a comment
There was a problem hiding this comment.
Tested, this PR fixes the issue. I tormented the commits with multiple mallets instances and with instrument switch being automated. No glitches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4617 and the underlying issue spotted by #2984.
For the stable branch, the second commit might be sufficient for fixing the bug.