Skip to content

Conversation

@thmueller64
Copy link
Contributor

This PR partly addresses #4749 and introduces the possibility to theme disabled knobs.
I could not get it to work using the pseudo state ":disabled" in the style sheets, as suggested in #4749. As the knob icons are png Images, we somehow have to catch the enabledChange event and convert the image to grayscale. Moreover, the pseudo-states do not seem to work with a custom QPROPERTY, in contrast to the standard ones like background-color etc. . So redrawing the middle line and arc does not seem possible with pseudo-states.

@LmmsBot
Copy link

LmmsBot commented May 2, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://6130-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6130?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://6131-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6131?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://6132-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6132?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/psn0bms0k36q0tae/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/32605119"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/b96wu8yagnodfh77/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/32605119"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://6128-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6128?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "b751f35859ea2ab0770544a469f22e875fbd33b3"}

@PhysSong
Copy link
Member

@thmueller64 Can we close this in favor of #5549?

@thmueller64
Copy link
Contributor Author

Yes, I've forgot to close this one, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants