-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Theming of disabled knobs #5481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
thmueller64
wants to merge
8
commits into
LMMS:master
from
thmueller64:fix-theming-of-disabled-knobs
Closed
Theming of disabled knobs #5481
thmueller64
wants to merge
8
commits into
LMMS:master
from
thmueller64:fix-theming-of-disabled-knobs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS
🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://6130-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6130?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://6131-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6131?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://6132-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6132?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/psn0bms0k36q0tae/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/32605119"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/b96wu8yagnodfh77/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/32605119"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://6128-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.648-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6128?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "b751f35859ea2ab0770544a469f22e875fbd33b3"} |
Member
|
@thmueller64 Can we close this in favor of #5549? |
Contributor
Author
|
Yes, I've forgot to close this one, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly addresses #4749 and introduces the possibility to theme disabled knobs.
I could not get it to work using the pseudo state ":disabled" in the style sheets, as suggested in #4749. As the knob icons are png Images, we somehow have to catch the
enabledChangeevent and convert the image to grayscale. Moreover, the pseudo-states do not seem to work with a customQPROPERTY, in contrast to the standard ones likebackground-coloretc. . So redrawing the middle line and arc does not seem possible with pseudo-states.