Skip to content

Automatically assign a midi input device to the selected track #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhysSong merged 4 commits into from
Jun 21, 2020
Merged

Automatically assign a midi input device to the selected track #5499

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a645853
Added the option to automatically assign a midi input device to the s…
LNooteboom May 15, 2020
07722eb
Fixed deassign midi device when a dialog is opened
LNooteboom Jun 1, 2020
cbcca21
Raw midi auto-assign
LNooteboom Jun 1, 2020
3c9a1e7
Changed yes to all in MIDI setup dialog
LNooteboom Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/gui/SetupDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,14 @@ SetupDialog::SetupDialog(ConfigTabs tab_to_open) :
m_assignableMidiDevices = new QComboBox(midiAutoAssign_tw);
m_assignableMidiDevices->setGeometry(10, 20, 240, 28);
m_assignableMidiDevices->addItem("none");
m_assignableMidiDevices->addItems(Engine::mixer()->midiClient()->readablePorts());
if ( !Engine::mixer()->midiClient()->isRaw() )
{
m_assignableMidiDevices->addItems(Engine::mixer()->midiClient()->readablePorts());
}
else
{
m_assignableMidiDevices->addItem("yes");
}
int current = m_assignableMidiDevices->findText(ConfigManager::inst()->value("midi", "midiautoassign"));
if (current >= 0)
{
Expand Down
6 changes: 6 additions & 0 deletions src/tracks/InstrumentTrack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,6 +940,12 @@ void InstrumentTrack::autoAssignMidiDevice(bool assign)
}

const QString &device = ConfigManager::inst()->value("midi", "midiautoassign");
if ( Engine::mixer()->midiClient()->isRaw() && device != "none" )
{
m_midiPort.setReadable( assign );
return;
}

// Check if the device exists
if ( Engine::mixer()->midiClient()->readablePorts().indexOf(device) >= 0 )
{
Expand Down