Add lv2 packages to Mac CI #5532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JohannesLorenz
commented
Jun 11, 2020
JohannesLorenz
commented
- Add lv2 packages to Mac CI
- When it fails (I hope it will) I'll fix the mac issue
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://8945-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e1-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8945?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://8944-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e132-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8944?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://8946-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e132-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8946?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/vaqhld5rbstly6b2/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35378884"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/l5aaneo0a9iar7qs/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35378884"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://8948-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e132-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8948?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "2e295a397ef1ce406a852c6d46e130eaf47e1e1e"} |
56 tasks
Contributor
Author
|
It failed for the reasons that will be fixed in #5536 . So I will merge this, but I will wait until 5536 has been fixed (in order to not crash our CI every time). |
JohannesLorenz
added a commit
that referenced
this pull request
Sep 21, 2020
... in order to make standard containers be able to store it. Required for #5532 (#4899) and the recording PR. This includes: * removing the `LocklessRingBuffer<sampleFrame>` specialization * passing samplerame in `StereoDelay::tick` as a reference Additional cleanups: * removing already unused typedef `sampleFrameA` * add some `const_cast` to make code more readable
JohannesLorenz
force-pushed
the
fix-lv2-macos
branch
from
e5e46c8 to
9b26317
Compare
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
... in order to make standard containers be able to store it. Required for LMMS#5532 (LMMS#4899) and the recording PR. This includes: * removing the `LocklessRingBuffer<sampleFrame>` specialization * passing samplerame in `StereoDelay::tick` as a reference Additional cleanups: * removing already unused typedef `sampleFrameA` * add some `const_cast` to make code more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.