Skip to content

Changes the behavior of "solo" so it doesn't mute Automation Tracks #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Spekular merged 12 commits into from
Aug 1, 2020
Merged

Changes the behavior of "solo" so it doesn't mute Automation Tracks #5547

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e09e695
Changes the toggleSolo method
IanCaio Jun 26, 2020
deb5d5c
Stop restoring Automation Track's mute values
IanCaio Jun 27, 2020
149ef0b
Saves two lines merging 2 conditionals in 1
IanCaio Jun 27, 2020
fdbc8b2
Adds the new solo behavior as a new LED button
IanCaio Jun 30, 2020
2f854d7
Revert "Adds the new solo behavior as a new LED button"
IanCaio Jun 30, 2020
0c16548
Adds an option to use the legacy solo behavior
IanCaio Jun 30, 2020
c60ac6b
Changes the description of the solo setting
IanCaio Jul 1, 2020
7efa9a2
Merge branch 'master' into feature/soloBehaviorChange
IanCaio Jul 29, 2020
16d48e1
Merges "if"s and "if-else"s where possible
IanCaio Jul 29, 2020
88a4b40
Uses default value instead of upgrading ConfigFile
IanCaio Jul 30, 2020
e924bb6
Removes repetitive method call
IanCaio Jul 30, 2020
3d69b4e
Saves one line of code and adds a comment
IanCaio Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/core/Track.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2653,7 +2653,14 @@ void Track::toggleSolo()
{
( *it )->m_mutedBeforeSolo = ( *it )->isMuted();
}
( *it )->setMuted( *it == this ? false : true );
// Don't mute AutomationTracks (keep their original state)
if( *it == this ){
( *it )->setMuted( false );
} else {
if( ( *it )->type() != AutomationTrack ){
( *it )->setMuted( true );
}
}
if( *it != this )
{
( *it )->m_soloModel.setValue( false );
Expand Down