B&B editor: adding and removing steps

[grejppi]

The 'Add/Remove steps' options on a pattern's context menu have been changed to always add and remove as many steps as there are in a full bar. The option to add or remove fewer steps is dropped.

Two new buttons are added to the B&B editor toolbar that perform these actions on all instrument tracks.

Rationale:

• The current way of adding new steps through a long context menu with a sub menu is awkward and requires precision. (Fitts's law)
• Current options are 1, 2, 4, 8, and 16 steps. In projects that are not in 4/4 time, the number of steps in a bar is none of those. Adding steps involves navigating the menu multple times.
• There is also no benefit in adding fewer than a full bar's worth of steps, as the B&B pattern length is finally rounded up to the nearest full bar.

[unfa]

No more re-doing the "add steps" for all instruments? Yay, this is finally
going to be useful!
On 18 Jan 2014 10:42, "grejppi" [email protected] wrote:

The 'Add/Remove steps' options on a pattern's context menu have been
changed to always add and remove as many steps as there are in a full bar.
The option to add or remove fewer steps is dropped.

Two new buttons are added to the B&B editor toolbar that perform these
actions on all instrument tracks.

Rationale:

• The current way of adding new steps through a long context menu with
  a sub menu is awkward and requires precision. (Fitts's lawhttp://en.wikipedia.org/wiki/Fitts's_law
  )
• Current options are 1, 2, 4, 8, and 16 steps. In projects that are
  not in 4/4 time, the number of steps in a bar is none of those. Adding
  steps involves navigating the menu multple times.
• There is also no benefit in adding fewer than a full bar's worth of
  steps, as the B&B pattern length is finally rounded up to the nearest full
  bar.

---

You can merge this Pull Request by running

git pull https://github.com/grejppi/lmms stable-0.4-bb_usability

Or view, comment on, or merge it at:

#56
Commit Summary

• b&b editor: always add and remove so many steps as there are in one
  bar
• add new steps to all tracks at once
• check track type first before adding or removing steps

File Changes

• M include/bb_editor.hhttps://github.com/B&B editor: adding and removing steps #56/files#diff-0(2)
• M include/pattern.hhttps://github.com/B&B editor: adding and removing steps #56/files#diff-1(9)
• M src/gui/bb_editor.cpphttps://github.com/B&B editor: adding and removing steps #56/files#diff-2(53)
• M src/tracks/pattern.cpphttps://github.com/B&B editor: adding and removing steps #56/files#diff-3(46)

Patch Links:

• https://github.com/LMMS/lmms/pull/56.patch
• https://github.com/LMMS/lmms/pull/56.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/56
.