Skip to content

Conversation

@JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Oct 3, 2020

This PR updates the remote URL (it has changed) and will (soon) contain a further commit to update rpmalloc.

No reviews/tests required. I'm just waiting for CI...

Fixes #4752
Fixes #4806 (at least, this is what we think)
Helps #5694

The remote has changed (it is still redirected, but that may change in
the future). So this commit reflects the remote change.

You must now run
```
git submodule sync --recursive
```
once to reflect this change.
@JohannesLorenz JohannesLorenz changed the title Update remote of sumodule rpmalloc Update remote and version of sumodule rpmalloc Oct 3, 2020
@LmmsBot
Copy link

LmmsBot commented Oct 3, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://9376-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-730%2Bgfa5ebbd-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9376?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://9379-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-730%2Bgfa5ebbdf1-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9379?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://9377-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-730%2Bgfa5ebbdf1-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9377?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/h5f1fv7wq8tcnnre/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35583135"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/8o6v6v6is5r99xa9/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35583135"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://9378-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-730%2Bgfa5ebbdf1-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/9378?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "511f2e4d6e5943ab472fc5839b0a543413837d00"}

@JohannesLorenz JohannesLorenz mentioned this pull request Oct 3, 2020
@JohannesLorenz
Copy link
Contributor Author

Remaining build error will (likely) be fixed after rpmalloc will have merged their PR 200. Thanks to Dom for the PR submission!

Fixes LMMS#4752
Fixes LMMS#4806 (at least, this is what we think)
Helps LMMS#5694
@JohannesLorenz JohannesLorenz merged commit c58c781 into LMMS:master Oct 5, 2020
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
This PR updates the remote URL and content of rpmalloc.

Fixes LMMS#4752
Fixes LMMS#4806 (assumably)
Helps LMMS#5694

You must now run
```
git submodule sync --recursive
```
once to reflect this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug when building on void linux Update rpmalloc

3 participants