Skip to content

4 new note modification tools #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanCaio merged 12 commits into from
Mar 5, 2021
Merged

4 new note modification tools #5857

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c461744
Add new note length modification tools
allejok96 Dec 23, 2020
59d65c1
"Last" instead of "latest"
allejok96 Dec 29, 2020
99796a6
Code formatting
allejok96 Dec 30, 2020
61a1433
Fix sort
allejok96 Jan 8, 2021
0cf824f
Fix incorrect cut of last note
allejok96 Jan 16, 2021
1839737
Fix Fill not stretching last note to end
allejok96 Jan 30, 2021
e1f5ee9
Fill from end positions
allejok96 Feb 3, 2021
10d6de1
Rename limitNoteLengths
allejok96 Feb 3, 2021
2832471
Compare with non-selected notes when filling
allejok96 Feb 3, 2021
f19331f
Style changes by IanCaio + bugfix
allejok96 Feb 5, 2021
1065f84
break instead of continue
allejok96 Feb 7, 2021
d5dcac2
Resolve knife conflict
allejok96 Feb 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Resolve knife conflict
  • Loading branch information
@allejok96
allejok96 committed Feb 28, 2021
commit d5dcac2c0f4932fc60bcfc0465e6af8bc3f025c0
6 changes: 6 additions & 0 deletions src/gui/editors/PianoRoll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4692,6 +4692,11 @@ PianoRollWindow::PianoRollWindow() :
connect(glueAction, SIGNAL(triggered()), m_editor, SLOT(glueNotes()));
glueAction->setShortcut( Qt::SHIFT | Qt::Key_G );

QAction * knifeAction = new QAction(embed::getIconPixmap("edit_knife"),
tr("Knife"), noteToolsButton);
connect(knifeAction, &QAction::triggered, m_editor, &PianoRoll::setKnifeAction);
knifeAction->setShortcut( Qt::SHIFT | Qt::Key_K );

QAction* fillAction = new QAction(embed::getIconPixmap("fill"), tr("Fill"), noteToolsButton);
connect(fillAction, &QAction::triggered, [this](){ m_editor->fitNoteLengths(true); });
fillAction->setShortcut(Qt::SHIFT | Qt::Key_F);
Expand All @@ -4707,6 +4712,7 @@ PianoRollWindow::PianoRollWindow() :
connect(maxLengthAction, &QAction::triggered, [this](){ m_editor->constrainNoteLengths(true); });

noteToolsButton->addAction(glueAction);
noteToolsButton->addAction(knifeAction);
noteToolsButton->addAction(fillAction);
noteToolsButton->addAction(cutOverlapsAction);
noteToolsButton->addAction(minLengthAction);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.