Fix drawNoteRect misalignments

[Veratil]

Partially Fixes #5863 (Notes misaligning, not keys visual glitch)

Tested with ghost notes, detuning, scrolling vertical and horizontal, and resizing the note edit area. Everything seems to be working as normal now for notes.

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.3.0-alpha.1.75%2Bg4dfeae4-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.3.0-alpha.1.75%2Bg4dfeae488-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha.1.75%2Bg4dfeae488-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

macOS

• macOS : lmms-1.3.0-alpha.1.75%2Bg4dfeae488-mac10.14.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12854-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.75%2Bg4dfeae4-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12854?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12855-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.75%2Bg4dfeae488-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12855?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12851-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.75%2Bg4dfeae488-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12851?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/5wtslsi4tgj8mnep/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38103737"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/cm9gpe5v1v59p2r3/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38103737"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12852-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.75%2Bg4dfeae488-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "3869e30e3374462002e0c0ddc267f88dcac53849"}

[PhysSong]

Code looks good. @RoxasKH Could you test this and confirm the fix?

[RoxasKH]

Code looks good. @RoxasKH Could you test this and confirm the fix?

Just tested it and it seems it's still buggy to me. It'd be better if someone else could test it, too, tho.

https://streamable.com/uvtzh6

[kalinushkin]

Code looks good. @RoxasKH Could you test this and confirm the fix?

Just tested it and it seems it's still buggy to me. It'd be better if someone else could test it, too, tho.

https://streamable.com/uvtzh6

Well, i tested it, and i find it correct working. "As by design" 👍

[RoxasKH]

Code looks good. @RoxasKH Could you test this and confirm the fix?

Just tested it and it seems it's still buggy to me. It'd be better if someone else could test it, too, tho.
https://streamable.com/uvtzh6

Well, i tested it, and i find it correct working. "As by design" 👍

No idea why it still happens to me, but i gotta admit i don't install properly LMMS versions to test them.
Maybe could also be related to resolution as i'm still on a 720p screen, but probably not.

[Veratil]

Code looks good. @RoxasKH Could you test this and confirm the fix?

Just tested it and it seems it's still buggy to me. It'd be better if someone else could test it, too, tho.

https://streamable.com/uvtzh6

This is for the notes, the artifacting on the piano keys is another issue I noticed that I'll look into later.

[RoxasKH]

Code looks good. @RoxasKH Could you test this and confirm the fix?

Just tested it and it seems it's still buggy to me. It'd be better if someone else could test it, too, tho.
https://streamable.com/uvtzh6

This is for the notes, the artifacting on the piano keys is another issue I noticed that I'll look into later.

Oh, thanks to point this out, i actually created the issue for the artifacts of the pianoroll keys so i never really noticed the notes bug while resizing.

Seems still a little buggy, but mostly unnoticeable.

https://streamable.com/d625ie

[superpaik]

In windows it doesn't work properly. When resizing the keys movement aren't smooth and sometimes they are keep unaligned . They get aligned again when the cursor enters the piano roll window.

[Veratil]

In windows it doesn't work properly. When resizing the keys movement aren't smooth and sometimes they are keep unaligned . They get aligned again when the cursor enters the piano roll window.

This PR is for the notes themselves, the piano keys I have to look into separately.

[PhysSong]

@Veratil Do you want to fix piano keys in this PR or in a separate PR?

[Veratil]

@Veratil Do you want to fix piano keys in this PR or in a separate PR?

I haven't figured out the reason for the piano keys glitch yet, but that will be a separate PR.

[PhysSong]

@Veratil Isn't the drawDetuningInfo call at line 3224 supposed to be fixed as well? Also, could you extract (topKey - note->key()) * m_keyLineHeight + keyAreaTop() - 1 to a variable to avoid repetitions and potential mistakes?

[Veratil]

@Veratil Isn't the drawDetuningInfo call at line 3224 supposed to be fixed as well?

I didn't seem to have any issues with detuning draw, but I can double check it again.

Also, could you extract (topKey - note->key()) * m_keyLineHeight + keyAreaTop() - 1 to a variable to avoid repetitions and potential mistakes?

Yeah that's reasonable. It'd have to be a lambda though since note->key() changes within the for loop.

[PhysSong]

This can potentially conflict with #5928, FYI.

[Veratil]

This can potentially conflict with #5928, FYI.

Double checking the diff for 5928, I don't see it touching these lines. It also still calculates the midpoint of the note based on the Y position given, so afaict we're safe on both. 👍

[Spekular]

I can confirm the issue Roxas encountered, but I think it may be the octave lines that are bugged, since they stay aligned with the buggy keyboard. Dragging the bottom of the piano roll window down exposes more and more of the next lowest key until a full key is visible, at which point the view jumps to expose the next higher key instead. Regardless of whether this is contributing to the octave line/note desync, it's rather unpleasant. The same occurs when dragging the top of the piano roll up.

In 1.2, the new notes at the top are smoothly revealed.

[Spekular]

Code wise changes LGTM. As for testing, piano roll resizing is still buggy, but this is an improvement over the existing behavior on master.

[Veratil]

I can confirm the issue Roxas encountered, but I think it may be the octave lines that are bugged, since they stay aligned with the buggy keyboard. Dragging the bottom of the piano roll window down exposes more and more of the next lowest key until a full key is visible, at which point the view jumps to expose the next higher key instead. Regardless of whether this is contributing to the octave line/note desync, it's rather unpleasant. The same occurs when dragging the top of the piano roll up.

I'll see what I can debug to prevent this state.

In 1.2, the new notes at the top are smoothly revealed.

I agree smooth reveal is better, and I'll aim to get back to that. 👍 For now we're slowly just fixing and cleaning the old, slow, and poorly maintained code. One step back, two steps forward. 😄