Changes comments and variables names

	Fixes some comments pointed out on Spekular's review. Changes the AutomationNode's variable m_key to m_pos (leaving a comment on the header reminding that it matches the timeMap key). Removes comments related to removed code. Fixes code style on a pointer declaration.

include/AutomationEditor.h

@@ -130,10 +130,6 @@ public slots:
 	float yCoordOfLevel( float level );
 	inline void drawLevelTick( QPainter & p, int tick, float value);// bool is_selected ); //NEEDS Change in CSS
 
-	// Returns the an iterator pointing to the AutomationNode on a radius of
-	// r pixels of the x,y mouse coordinates, or timeMap.end() if there are none.
-	// If outValue is true, we will check if the coordinates in relation to the
-	// outValue sphere instead of the inValue.
 	timeMap::iterator getNodeAt(int x, int y, bool outValue = false, int r = 5);
 
 	void drawLine( int x0, float y0, int x1, float y1 );
@@ -236,7 +232,7 @@ protected slots:
 	int m_y_delta;
 	bool m_y_auto;
 
-	// Time position (key) of automation node whose's outValue is being dragged
+	// Time position (key) of automation node whose outValue is being dragged
 	int m_draggedOutValueKey;
 
 	EditModes m_editMode;

include/AutomationNode.h

@@ -34,8 +34,8 @@ class AutomationNode
 {
 public:
 	AutomationNode(); // Dummy constructor for the QMap
-	AutomationNode(AutomationPattern* pat, float value, int key);
-	AutomationNode(AutomationPattern* pat, float inValue, float outValue, int key);
+	AutomationNode(AutomationPattern* pat, float value, int pos);
+	AutomationNode(AutomationPattern* pat, float inValue, float outValue, int pos);
 
 	inline float getInValue()
 	{
@@ -118,8 +118,8 @@ class AutomationNode
 	// Pattern that this node belongs to
 	AutomationPattern* m_pattern;
 
-	// Time position of this node
-	int m_key;
+	// Time position of this node (matches the timeMap key)
+	int m_pos;
 
 	// Values of this node
 	float m_inValue;

src/core/AutomationNode.cpp

@@ -31,27 +31,27 @@
 // Dummy constructor for the QMap
 AutomationNode::AutomationNode() :
 	m_pattern(nullptr),
-	m_key(0),
+	m_pos(0),
 	m_inValue(0),
 	m_outValue(0),
 	m_inTangent(0),
 	m_outTangent(0)
 {
 }
 
-AutomationNode::AutomationNode(AutomationPattern* pat, float value, int key) :
+AutomationNode::AutomationNode(AutomationPattern* pat, float value, int pos) :
 	m_pattern(pat),
-	m_key(key),
+	m_pos(pos),
 	m_inValue(value),
 	m_outValue(value),
 	m_inTangent(0),
 	m_outTangent(0)
 {
 }
 
-AutomationNode::AutomationNode(AutomationPattern* pat, float inValue, float outValue, int key) :
+AutomationNode::AutomationNode(AutomationPattern* pat, float inValue, float outValue, int pos) :
 	m_pattern(pat),
-	m_key(key),
+	m_pos(pos),
 	m_inValue(inValue),
 	m_outValue(outValue),
 	m_inTangent(0),
@@ -71,7 +71,7 @@ void AutomationNode::setInValue(float value)
 	AutomationPattern::timeMap & tm = m_pattern->getTimeMap();
 
 	// Get an iterator pointing to this node
-	AutomationPattern::timeMap::iterator it = tm.lowerBound(m_key);
+	AutomationPattern::timeMap::iterator it = tm.lowerBound(m_pos);
 	// If it's not the first node, get the one immediately behind it
 	if (it != tm.begin())
 	{
@@ -94,7 +94,7 @@ void AutomationNode::setOutValue(float value)
 	AutomationPattern::timeMap & tm = m_pattern->getTimeMap();
 
 	// Get an iterator pointing to this node
-	AutomationPattern::timeMap::iterator it = tm.lowerBound(m_key);
+	AutomationPattern::timeMap::iterator it = tm.lowerBound(m_pos);
 	// If it's not the first node, get the one immediately behind it
 	if (it != tm.begin())
 	{

src/core/AutomationPattern.cpp

@@ -169,7 +169,7 @@ const AutomatableModel * AutomationPattern::firstObject() const
 {
 	QMutexLocker m(&m_patternMutex);
 
-	AutomatableModel * model;
+	AutomatableModel* model;
 	if (!m_objects.isEmpty() && (model = m_objects.first()) != nullptr)
 	{
 		return model;
@@ -409,7 +409,7 @@ float AutomationPattern::valueAt( const MidiTime & _time ) const
 
 
 
-// This method will get the value at a offset from a node, so we use the outValue of
+// This method will get the value at an offset from a node, so we use the outValue of
 // that node and the inValue of the next node to the calculations. This assumes that offset
 // will not be zero, because when the midi time given to AutomationPattern::valueAt(MidiTime)
 // matches a node's position, that node's value will be returned and this method won't be even

src/gui/editors/AutomationEditor.cpp

@@ -1016,13 +1016,13 @@ inline void AutomationEditor::drawAutomationPoint(QPainter & p, timeMap::iterato
 	int y;
 	const int outerRadius = qBound(3, (m_ppb * AutomationPattern::quantization()) / 576, 5); // man, getting this calculation right took forever
 
-	// Draws an ellipse for the outValue
+	// Draw a circle for the outValue
 	y = yCoordOfLevel(it.value().getOutValue());
 	p.setPen(QPen(nodeOutValueColor().lighter(200)));
 	p.setBrush(QBrush(nodeOutValueColor()));
 	p.drawEllipse(x - outerRadius, y - outerRadius, outerRadius * 2, outerRadius * 2);
 
-	// Draws an ellipse for the inValue
+	// Draw a circle for the inValue
 	y = yCoordOfLevel(it.value().getInValue());
 	p.setPen(QPen(nodeInValueColor().lighter(200)));
 	p.setBrush(QBrush(nodeInValueColor()));
@@ -1403,9 +1403,7 @@ float AutomationEditor::yCoordOfLevel(float level )
 
 
 
-//NEEDS Change in CSS
 void AutomationEditor::drawLevelTick(QPainter & p, int tick, float value)
-				//			bool is_selected )
 {
 	QMutexLocker m(&m_patternEditorMutex);
 
@@ -1904,9 +1902,9 @@ void AutomationEditor::updateTopBottomLevels()
 
 
 /* @brief Given a mouse coordinate, returns a timeMap::iterator that points to
- *        the latest node that is inside a square of side "r" pixels from those
- *        coordinates. In simpler terms, returns the automation node that was
- *        clicked.
+ *        the latest node inside a square of side "r" pixels from those
+ *        coordinates. In simpler terms, returns the automation node on those
+ *        coordinates.
  * @param Int X coordinate
  * @param Int Y coordinate
  * @param Boolean. True to check if the outValue of the node was clicked instead

src/gui/editors/PianoRoll.cpp

@@ -980,8 +980,8 @@ void PianoRoll::drawDetuningInfo( QPainter & _p, const Note * _n, int _x,
 		width() - m_whiteKeyWidth,
 		keyAreaBottom() - PR_TOP_MARGIN);
 
-	// Draws the lines for the detuning automation. Just as previously, we are still
-	// drawing cubic hermit curves as lines too. Now account for discrete jumps.
+	// Draw lines for the detuning automation, treating cubic hermit curves
+	// as straight lines. Also draw discrete jumps.
 	int old_x = 0;
 	int old_y = 0;