Fix misalignment of knobs caused by wide labels #5934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12819-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fd-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12819?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12820-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fdbe-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12820?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12817-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fdbe-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12817?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/mjht54po6ony3bxc/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38093923"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/n5shlgniscx5a824/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38093923"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12816-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.74%2Bg70c02fdbe-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12816?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "ac5e36cbd1ea09087aa6eb8631663200c9c4fa53"} |
tresf
added
rework required
Contributor
|
Knob internals were modified quite a bit in #7525. Mentioning this since it's relevant for future work on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the main cause of #5518. The positions are now recalculated when setting the label so that the knobs stay in place more or less. Also corrected the dirty compensations in builtin effects.