Fix PianoRoll m_positionLine misalignment on zoom#5965
Merged
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://13208-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg1eeb855-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13208?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://13206-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg1eeb8555d-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13206?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://13209-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg1eeb8555d-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13209?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/add31i6g7eysnxjk/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38413938"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/dn4vflileilgwm49/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38413938"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://13207-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg1eeb8555d-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13207?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "5d7a4a32f07d754e2cc8620629f134b1cdf75203"} |
IanCaio
approved these changes
Mar 26, 2021
Contributor
IanCaio
left a comment
IanCaio
left a comment
There was a problem hiding this comment.
LGTM! Suggested a small fix on the comment about the width
| if (pos >= m_currentPosition && pos <= m_currentPosition + width() - m_whiteKeyWidth) | ||
| // ticks relative to m_currentPosition | ||
| // < 0 = outside viewport left | ||
| // > width = outside viewport right |
Contributor
There was a problem hiding this comment.
Suggested change
| // > width = outside viewport right | |
| // > (width - piano keys width) = outside viewport right |
Contributor
|
It look good to me (windows 10) |
|
There's no problem in the win64 build now, I am using win10. Thanks. |
Contributor
Author
|
Merging tomorrow unless anyone objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5962
Adds comments to elaborate on what is being calculated.