Skip to content

Remove 'using namespace std;' from LMMS headers #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohannesLorenz merged 9 commits into from
Jul 23, 2021
Merged

Remove 'using namespace std;' from LMMS headers #6076

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6127dc9
Remove 'using namespace std;' from lmms_math.h
irrenhaus3 Jul 12, 2021
6afdd75
Missed one in vestige.
irrenhaus3 Jul 12, 2021
dca9f56
Missed a more subtle one in Compressor
irrenhaus3 Jul 12, 2021
2dddbf9
And another subtle one in GigPlayer
irrenhaus3 Jul 12, 2021
e65b601
Update ref for ZynAddSubFX
irrenhaus3 Jul 17, 2021
d855583
Temporary URL for Zyn submodule
irrenhaus3 Jul 17, 2021
f33c14a
Point Zyn back at LMMS repo
irrenhaus3 Jul 17, 2021
74e2755
Forgot to restore URL in the actual submodule.
irrenhaus3 Jul 17, 2021
1d72ec7
Update zyn submodule to latest commit.
irrenhaus3 Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Missed a more subtle one in Compressor
  • Loading branch information
@irrenhaus3
irrenhaus3 committed Jul 12, 2021
commit dca9f566eb7f01a3b91798136520a8f239ece3b9
2 changes: 1 addition & 1 deletion plugins/Compressor/Compressor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ bool CompressorEffect::processAudioBuffer(sampleFrame* buf, const fpp_t frames)
m_rmsVal[i] = m_rmsTimeConst * m_rmsVal[i] + ((1 - m_rmsTimeConst) * (inputValue * inputValue));

// Grab the peak or RMS value
inputValue = qMax(COMP_NOISE_FLOOR, peakmode ? abs(inputValue) : sqrt(m_rmsVal[i]));
inputValue = qMax(COMP_NOISE_FLOOR, peakmode ? std::abs(inputValue) : std::sqrt(m_rmsVal[i]));

// The following code uses math magic to semi-efficiently
// find the largest value in the lookahead buffer.
Expand Down