Skip to content

Macro cleanup #6095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohannesLorenz merged 33 commits into from
Sep 30, 2021
Merged

Macro cleanup #6095

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
13d84a7
Replace NULL macro with nullptr value in all C++ files.
irrenhaus3 Jul 17, 2021
8d6dba7
Use standard macro instead of redefining 'assert'
irrenhaus3 Jul 17, 2021
f800292
Remove macro 'pluginFactory', replace with global function 'getPlugin…
irrenhaus3 Jul 17, 2021
42a294b
Remove macro 'gui', replace with global function 'getGUI()'
irrenhaus3 Jul 17, 2021
f9af93f
Replace MM_ALLOC and MM_FREE macros with equivalent function templates.
irrenhaus3 Jul 18, 2021
cd85c8a
Move #include directive to top of AudioEngine.h and replace a missed …
irrenhaus3 Jul 21, 2021
03f615a
Replace a bunch of NULL macros in LMMS header files
irrenhaus3 Jul 21, 2021
3531fe8
Replace automation node macros (INVAL, OUTVAL etc) in AutomationNode.…
irrenhaus3 Jul 21, 2021
dfa6e28
Remove macro-based redefinition of glibc math extension 'exp10', and …
irrenhaus3 Jul 24, 2021
791117b
Replace integer constant macros with constexpr values in BandLimitedW…
irrenhaus3 Jul 25, 2021
1b3d111
Replace integer constant macro with constexpr in lmms_math.h
irrenhaus3 Jul 31, 2021
ac0f8e1
Rename two header include guards to match the _H naming scheme
irrenhaus3 Jul 31, 2021
c490104
powf -> std::pow in DrumSynth.cpp
irrenhaus3 Jul 31, 2021
134e81d
Remove unused macros in DrumSynth.cpp
irrenhaus3 Jul 31, 2021
14c8a61
Replace PATH_DEV_DSP string macro with file-scope QString in AudioOss…
irrenhaus3 Jul 31, 2021
ccf3ecf
math.h -> cmath in DrumSynth.cpp
irrenhaus3 Aug 15, 2021
1c35faf
Macro constant -> constexpr constant in AudioEngineWorkerThread.h
irrenhaus3 Aug 18, 2021
20474f8
Apply gui macro -> getGUI() function replacement to Microtuner PR
irrenhaus3 Sep 9, 2021
8043556
Make a bunch of global constants compile-time-evaluable.
irrenhaus3 Sep 9, 2021
c2a839c
Replace a buffer size limit and memory align size macros with size_t …
irrenhaus3 Sep 9, 2021
1aa61a7
Make volume constants compile-time-evaluable.
irrenhaus3 Sep 9, 2021
8064d3d
Make constants in lmms_basics.h compile-time evaluable.
irrenhaus3 Sep 9, 2021
1d70410
Replace macro QSTR_TO_STDSTR with inline function.
irrenhaus3 Sep 9, 2021
46e41a6
Replace LADSPA_PATH_SEPARATOR and UI_CTRL_KEY with typed global const…
irrenhaus3 Sep 9, 2021
846fa37
Replace F_OPEN_UTF8 macro with equivalent function.
irrenhaus3 Sep 10, 2021
6711922
Prefix macros in versioninfo.h with LMMS_BUILDCONF_ for better name s…
irrenhaus3 Sep 11, 2021
33074ff
Replace macro VST_SNC_SHM_KEY_FILE with a string literal.
irrenhaus3 Sep 11, 2021
28cc967
Make CCONST a constexpr function and make int constants in aeffectx.h…
irrenhaus3 Sep 11, 2021
6facbee
Convert LMMS_BUILDCONF macros in versioninfo.h to string literals.
irrenhaus3 Sep 11, 2021
725c69f
Add message to static_assert for pre-C++17 compat.
irrenhaus3 Sep 11, 2021
1f5efff
Until we switch to a newer portsmf version, throw std::out_of_range i…
irrenhaus3 Sep 17, 2021
93d7929
constexpr number intializers: Change braces to assignment op notation.
irrenhaus3 Sep 17, 2021
f9818a3
Replace C-style casts around std::pow calls in DrumSynth with static_…
irrenhaus3 Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make constants in lmms_basics.h compile-time evaluable.
  • Loading branch information
@irrenhaus3
irrenhaus3 committed Sep 25, 2021
commit 8064d3dfbf13e91612ace17a240dd588a246eb1f
4 changes: 2 additions & 2 deletions include/lmms_basics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ inline bool typeInfo<float>::isEqual( float x, float y )



const ch_cnt_t DEFAULT_CHANNELS = 2;
constexpr ch_cnt_t DEFAULT_CHANNELS = 2;

const ch_cnt_t SURROUND_CHANNELS =
constexpr ch_cnt_t SURROUND_CHANNELS =
#define LMMS_DISABLE_SURROUND
#ifndef LMMS_DISABLE_SURROUND
4;
Expand Down