-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Journalling UUIDs #6452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
irrenhaus3
wants to merge
23
commits into
LMMS:master
Choose a base branch
from
irrenhaus3:connection-ids
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Journalling UUIDs #6452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/16f63bbb-e1c5-41dd-bff6-37fa3a734b09/artifacts/0/lmms-1.3.0-alpha.1.223+ga8d48366f-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17601?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/e350ca33-ed24-4088-939b-336e930589fc/artifacts/0/lmms-1.3.0-alpha.1.223+ga8d48366f-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17604?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/f1a22c3a-9769-4173-9be4-b8b91d9976aa/artifacts/0/lmms-1.3.0-alpha.1.223+ga8d48366f-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17605?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/8igbqeygbg5gtw1u/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43991481"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/vceoc04g1hg41ddm/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43991481"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://output.circle-artifacts.com/output/job/4e93d6aa-b6c7-4b74-956c-290ef266f699/artifacts/0/lmms-1.3.0-alpha.1.223+ga8d48366f-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17603?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "1b4d2f88112ff08d1c7cbe3c3838092767b87aee"} |
…d was used directly to use that class instead.
…ntirely removed later.
…D update semantics.
…. Fixes RemotePlugin builds.
…ame collisions with Macros.
Contributor
|
I like the concept of removing possibilities of collision bw ids (though i don't understand anything about uuids). But since the plan is to get rid of qt, my question is - is it doable without using qt? If not qt, what's the way? |
Contributor
|
Does this fix the bug of restoring ID of objects when undoing? Steps to reproduce:
|
…o use stduuid instead of QUuid; new header for compatibility of this type with marshalling contexts like QVariant.
1b4d2f8 to
dbc25e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a UUID utility class and uses it to provide the type of
jo_id_t. The intent is to remove any realistic possibility of collision between JournallingObject IDs.This addresses issue #4736 and supersedes PRs #2875 and #4723.
What's been tested to work so far?
What doesn't work?
RemotePluginfixed with b1c205cTODOs?