Fix recent files menu on old KDE in a different way #6612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wheeeeeeeee |
sakertooth
pushed a commit
to sakertooth/lmms
that referenced
this pull request
May 30, 2023
sakertooth
pushed a commit
to sakertooth/lmms
that referenced
this pull request
May 30, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6587.
This PR reverts #3872 and applies an alternative fix for #3741. In the previous approach,
KAcceleratorManager::setNoAccelwas called with theMainWindowinstance. This, however, leads to a crash in certain cases as reported by #6587.KXmlGui library registers a startup function for
QCoreApplicationwhich may install aKCheckAcceleratorsglobal event filter, usingKCheckAcceleratorsInitializer. The event filter is supposed to be installed only if the application directly links to KXmlGui, but it was always installed prior to KXmlGui 5.55.0.The new approach has two advantages:
As far as know, CentOS 7, Ubuntu 18.04 and Debian 10 ships with buggy versions of the library. Once all of them gets unsupported, we may entirely remove the workaround.