Fix scale highlighting with vertical zooming #6761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertically zooming the piano roll caused highlighted semitones to drift from the actual note positions. This 2-line fix ensures the marked semitones are aligned with the grid lines and notes at all allowed vertical zoom levels.
PhysSong
approved these changes
Jul 30, 2023
Contributor
|
Dead on target! Looks fine to me. There is something else going on there but it wasn't caused by this PR. When you scroll, there is an update missing somewhere. While you're scrolling the lines are still off but when you move the cursor over the note area the keyboard and highlight lines suddenly nudge into position. |
zonkmachine
approved these changes
Jul 30, 2023
DomClark
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertically zooming the piano roll caused highlighted semitones to drift from the actual note positions. This 2-line fix ensures the marked semitones are aligned with the grid lines and notes at all available vertical zoom levels.
Although this works on my low-resolution linux device, I am unable to test if display scaling (e.g. for 4k screens), OS differences (or other factors I have not considered) play well with this patch.
This might conflict with other pull requests that affect the piano roll like #6700