Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
36ec16a
merged with upstream
szeli1 Apr 13, 2024
94d9003
arp_style_changes
szeli1 Dec 22, 2023
dc0c0f1
added merge changes back
szeli1 Apr 13, 2024
30b28db
changes applyed to merge
szeli1 Apr 13, 2024
7a7214b
InstrumentFunctions_sorting_replaced_with_stdless
szeli1 Apr 23, 2024
b28b4cc
InstrumentFunctions_range_combined_with_sortOffset
szeli1 Apr 23, 2024
10c33b5
InstrumentFunctions_std_div_instead_of_operators
szeli1 Apr 24, 2024
6f51813
InstrumentFunctions_reworked_sorting
szeli1 May 9, 2024
3bf63c4
InstrumentFunctions_finished_sort_changes
szeli1 May 10, 2024
fba9e31
InstrumentSoundShaping_envelope_now_uses_parent_note
szeli1 May 10, 2024
44df07e
EnvelopeAndLFOParameters_added_checkbox
szeli1 May 11, 2024
164f165
InstrumentFunctions_fixed_sort_order
szeli1 May 12, 2024
f6f2654
Revert "EnvelopeAndLFOParameters_added_checkbox"
szeli1 May 15, 2024
f8622f8
Revert "InstrumentSoundShaping_envelope_now_uses_parent_note"
szeli1 May 15, 2024
a86651a
InstrumentFunctions_arp_order_octave_arp_piano
szeli1 Jun 8, 2024
7b09570
InstrumentFunctions_style_changes
szeli1 Jun 8, 2024
975352c
InstrumentFunctions_introduced_arpMode_variable
szeli1 Jun 15, 2024
1dc8a81
InstrumentFunctions_replaced_offsetRange_by_range
szeli1 Jun 15, 2024
a7f49bc
InstrumentFunctions_added_return_instead_of_break
szeli1 Jun 15, 2024
6e9e626
InstrumentFunctions_removed_old_code
szeli1 Jun 15, 2024
a534b31
InstrumentFunctions_implemented_cnphv_sorting
szeli1 Jun 15, 2024
0c0b19f
InstrumentFunctions_removed_include_QMutex
szeli1 Jun 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added merge changes back
  • Loading branch information
szeli1 committed Apr 13, 2024
commit dc0c0f13bab564e11cf4200dbf23b6ecf903116c
6 changes: 3 additions & 3 deletions src/core/InstrumentFunctions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -480,12 +480,12 @@ void InstrumentFunctionArpeggio::processNote( NotePlayHandle * _n )
// once down -> makes 2 * range possible notes...
// because we don't play the lower and upper notes
// twice, we have to subtract 2
cur_arp_idx = (cur_frame / arp_frames) % ((range + sortOffset) * 2 - 2);
cur_arp_idx = (cur_frame / arp_frames) % (range * 2 - (2 * static_cast<int>(m_arpRepeatsModel.value())));
// if greater than range, we have to play down...
// looks like the code for arp_dir==DOWN... :)
if (cur_arp_idx >= range + sortOffset)
if (cur_arp_idx >= range)
{
cur_arp_idx = range + sortOffset - cur_arp_idx % (range + sortOffset - 1) - 1;
cur_arp_idx = range - cur_arp_idx % (range - 1) - static_cast<int>(m_arpRepeatsModel.value());
}
}
else if (dir == ArpDirection::DownAndUp && (range + sortOffset) > 1)
Expand Down