Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
5aa542d
Render fader levels in code with a gradient
michaelgregorius Dec 30, 2023
dac9208
Remove unused pixmaps from `Fader`
michaelgregorius Dec 30, 2023
9a4082a
Rename peak properties and use them to render levels
michaelgregorius Dec 30, 2023
c9e83a3
Always render the knob in the middle of the fader
michaelgregorius Dec 30, 2023
ec4830f
Set size policy of fader to minimum expanding
michaelgregorius Dec 30, 2023
8051134
Default dbFS levels and better peak values
michaelgregorius Jan 1, 2024
3b7cc15
Fix faders of Crossover EQ
michaelgregorius Jan 1, 2024
796661a
Remove EqFader constructor with pixmaps
michaelgregorius Jan 1, 2024
cc6a7d9
Remove background and LEDs pixmap from Fader constructor
michaelgregorius Jan 1, 2024
50781de
Remove the init method from Fader
michaelgregorius Jan 1, 2024
0126c02
Merge remote-tracking branch 'upstream/master' into FaderInCodeWithGr…
michaelgregorius Jan 2, 2024
045a2cd
Draw unity lines last
michaelgregorius Jan 3, 2024
a644bdc
Introduce range with solid warn color
michaelgregorius Jan 6, 2024
381257b
Remove unused method Fader::clips
michaelgregorius Jan 6, 2024
0aebb8c
Fader: Correctly render arbitrary ranges
michaelgregorius Jan 6, 2024
e4b8b6b
Fix whitespace
michaelgregorius Jan 6, 2024
e48bbb8
Remove unused methods in PaintHelper
michaelgregorius Jan 6, 2024
e1fd07f
Fix some builds
michaelgregorius Jan 6, 2024
99113c3
Opaque unity marker with styling option
michaelgregorius Jan 6, 2024
a44b654
Darker default color for the unity line
michaelgregorius Jan 7, 2024
e67f5f8
Remove TODO
michaelgregorius Jan 7, 2024
bb39d5a
Move code
michaelgregorius Jan 8, 2024
5627384
Render unity lines in background
michaelgregorius Jan 8, 2024
b639dc5
Don't draw transparent white lines anymore
michaelgregorius Jan 8, 2024
3bfc4e4
Full on clip color at unity
michaelgregorius Jan 8, 2024
c2dd209
Fix discrepancy between levels and unity markers
michaelgregorius Jan 8, 2024
0f3ce40
Merge remote-tracking branch 'upstream/master' into FaderInCodeWithGr…
michaelgregorius Jan 25, 2024
449ab02
Fix fader display for Equalizer shelves and peaks
michaelgregorius Feb 23, 2024
b4bfc71
Improve the rendering of the levels
michaelgregorius Mar 10, 2024
6d7e7c4
Merge remote-tracking branch 'upstream/master' into FaderInCodeWithGr…
michaelgregorius Mar 22, 2024
f2d63ec
Reduce code repetition
michaelgregorius Apr 3, 2024
2bec339
Code review changes
michaelgregorius Apr 3, 2024
b3a1dd9
Move const to the left of types
michaelgregorius Apr 3, 2024
1bd81d8
Use MEMBER instead of READ/WRITE
michaelgregorius Apr 3, 2024
ad8a31d
Use default member initializers for Fader
michaelgregorius Apr 3, 2024
a65b8aa
Remove constexpr again
michaelgregorius Apr 3, 2024
dea9423
Comprehensive code formatting in Fader class
michaelgregorius Apr 3, 2024
bb212ee
Improved capture and formatting
michaelgregorius Apr 3, 2024
a74b214
Merge remote-tracking branch 'upstream/master' into FaderInCodeWithGr…
michaelgregorius Apr 3, 2024
b0e4586
Make code clearer
michaelgregorius Apr 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make code clearer
Make code clearer in `Fader::FadermouseDoubleClickEvent`. Only divide if the dialog was accepted with OK.
  • Loading branch information
michaelgregorius committed Apr 3, 2024
commit b0e4586ceade83834d148bb684a22df85f47de7f
9 changes: 4 additions & 5 deletions src/gui/widgets/Fader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,16 @@ void Fader::mousePressEvent(QMouseEvent* mouseEvent)
void Fader::mouseDoubleClickEvent(QMouseEvent* mouseEvent)
{
bool ok;
// TODO: dbV handling
// TODO: dbFS handling
auto minv = model()->minValue() * m_conversionFactor;
auto maxv = model()->maxValue() * m_conversionFactor;
float newValue = QInputDialog::getDouble(this, tr("Set value"),
float enteredValue = QInputDialog::getDouble(this, tr("Set value"),
tr("Please enter a new value between %1 and %2:").arg(minv).arg(maxv),
model()->getRoundedValue() * m_conversionFactor, minv, maxv, model()->getDigitCount(), &ok)
/ m_conversionFactor;
model()->getRoundedValue() * m_conversionFactor, minv, maxv, model()->getDigitCount(), &ok);

if (ok)
{
model()->setValue(newValue);
model()->setValue(enteredValue / m_conversionFactor);
}
}

Expand Down