Skip to content

Refactor gui_templates.h #7159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sakertooth merged 10 commits into from
Mar 27, 2024
Merged

Refactor gui_templates.h #7159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
44c95f8
remove the gui_templates header where functions not used
Rossmaxx Mar 24, 2024
63799cc
refactor and replace template with function argument
Rossmaxx Mar 24, 2024
2945a6c
refactor: merge pointSizeF function with pointSize
Rossmaxx Mar 24, 2024
832cf78
missed these
Rossmaxx Mar 24, 2024
137b5d5
removed template per michael's review
Rossmaxx Mar 24, 2024
296583e
use std::max for more readability
Rossmaxx Mar 24, 2024
76cf4a7
remove the QDesktopWidget header
Rossmaxx Mar 24, 2024
9513333
headers
Rossmaxx Mar 24, 2024
1f2cba0
cleanup arguments and remove parantheses from return
Rossmaxx Mar 27, 2024
9ce2993
namespace gui
Rossmaxx Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove the gui_templates header where functions not used
  • Loading branch information
@Rossmaxx
Rossmaxx committed Mar 24, 2024
commit 44c95f82e963057b5d163305141ede5c9d98f22b
1 change: 0 additions & 1 deletion src/core/audio/AudioJack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include "LcdSpinBox.h"
#include "MainWindow.h"
#include "MidiJack.h"
#include "gui_templates.h"

namespace lmms
{
Expand Down
1 change: 0 additions & 1 deletion src/core/audio/AudioOss.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include "LcdSpinBox.h"
#include "AudioEngine.h"
#include "Engine.h"
#include "gui_templates.h"

#ifdef LMMS_HAVE_UNISTD_H
#include <unistd.h>
Expand Down
1 change: 0 additions & 1 deletion src/core/audio/AudioPortAudio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ void AudioPortAudioSetupUtil::updateChannels()

#include "Engine.h"
#include "ConfigManager.h"
#include "gui_templates.h"
#include "ComboBox.h"
#include "AudioEngine.h"

Expand Down
1 change: 0 additions & 1 deletion src/core/audio/AudioPulseAudio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#include "ConfigManager.h"
#include "LcdSpinBox.h"
#include "AudioEngine.h"
#include "gui_templates.h"
#include "Engine.h"

namespace lmms
Expand Down
1 change: 0 additions & 1 deletion src/core/audio/AudioSdl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@

#include "AudioEngine.h"
#include "ConfigManager.h"
#include "gui_templates.h"

namespace lmms
{
Expand Down
1 change: 0 additions & 1 deletion src/core/audio/AudioSndio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include "LcdSpinBox.h"
#include "AudioEngine.h"
#include "Engine.h"
#include "gui_templates.h"

#include "ConfigManager.h"

Expand Down
1 change: 0 additions & 1 deletion src/core/audio/AudioSoundIo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#include "Engine.h"
#include "debug.h"
#include "ConfigManager.h"
#include "gui_templates.h"
#include "ComboBox.h"
#include "AudioEngine.h"

Expand Down
1 change: 0 additions & 1 deletion src/gui/AudioAlsaSetupWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

#include "ConfigManager.h"
#include "LcdSpinBox.h"
#include "gui_templates.h"

namespace lmms::gui
{
Expand Down
1 change: 0 additions & 1 deletion src/gui/MidiSetupWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include <QLineEdit>

#include "ConfigManager.h"
#include "gui_templates.h"


namespace lmms::gui
Expand Down
1 change: 0 additions & 1 deletion src/gui/SampleTrackWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

#include "EffectRackView.h"
#include "embed.h"
#include "gui_templates.h"
#include "GuiApplication.h"
#include "Knob.h"
#include "MainWindow.h"
Expand Down
1 change: 0 additions & 1 deletion src/gui/menus/MidiPortMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
*/

#include "MidiPortMenu.h"
#include "gui_templates.h"

namespace lmms::gui
{
Expand Down
1 change: 0 additions & 1 deletion src/gui/modals/SetupDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include "embed.h"
#include "Engine.h"
#include "FileDialog.h"
#include "gui_templates.h"
#include "MainWindow.h"
#include "MidiSetupWidget.h"
#include "ProjectJournal.h"
Expand Down
1 change: 0 additions & 1 deletion src/gui/tracks/TrackOperationsWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#include "DataFile.h"
#include "embed.h"
#include "Engine.h"
#include "gui_templates.h"
#include "InstrumentTrackView.h"
#include "PixmapButton.h"
#include "Song.h"
Expand Down