Skip to content

PathUtil std::string support #7246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
messmerd wants to merge 21 commits into
base: master
Choose a base branch
from
Open

PathUtil std::string support #7246

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3e3d5b1
Add std::string support and Internal Base location to PathUtil
messmerd May 8, 2024
6103e74
Simplify cleanName function
messmerd May 8, 2024
094cba7
Fix tests
messmerd May 8, 2024
3785c50
Address some review comments
messmerd May 13, 2024
69c5492
Add lmms_filesystem.h
messmerd May 14, 2024
7c9c282
Remove several QString-based PathUtil functions
messmerd May 14, 2024
ae3b485
Add unit tests for PathUtil::cleanName()
messmerd May 14, 2024
aa54eda
Try to fix MinGW build
messmerd May 14, 2024
91b0d95
Merge branch 'LMMS:master' into pathutils
messmerd May 23, 2024
53ffc75
Use std::filesystem
messmerd May 24, 2024
c07347b
Introduce UTF-8 string aliases; style
messmerd May 24, 2024
37aadf3
Temporarily use verbose test output
messmerd May 24, 2024
6ea9a6b
Oops
messmerd May 24, 2024
1909a1e
Sanity check
messmerd May 29, 2024
8c1fc6d
Merge branch 'master' into pathutils
messmerd Jul 8, 2025
0ff689b
Update for C++20
messmerd Jul 8, 2025
1f64d0c
Improvements
messmerd Jul 8, 2025
96d0466
Fix tests on Windows MSVC
messmerd Jul 9, 2025
2db4119
Better comments
messmerd Jul 9, 2025
aaebd0a
Fix toShortestRelative edge case
messmerd Jul 9, 2025
3431d54
Try debugging MSVC failure
messmerd Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Try debugging MSVC failure
  • Loading branch information
@messmerd
messmerd committed Jul 9, 2025
commit 3431d54b2bd934a421ef2524f492d5d46a3e43c9
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ jobs:
- name: Run tests
run: |
cd build/tests
ctest --verbose --output-on-failure
ctest --debug --output-on-failure
- name: Package
run: cmake --build build --target package
- name: Upload artifacts
Expand Down
Loading