Skip to content

Conversation

@notaz
Copy link
Contributor

@notaz notaz commented Jun 10, 2024

In my setup (Ubuntu 22.04 + wine-9.10 (Staging)) the wine Vst process doesn't have a parent and gets killed by PollParentThread shortly after start. Strangely this only happens in 64bit mode and not in 32bit.

In either case it's a bad idea to rely on wine created process having a parent or not because the wine project may change this anytime.

In my setup (Ubuntu 22.04 + wine-9.10 (Staging)) the wine Vst process
doesn't have a parent and gets killed by PollParentThread shortly after
start. Strangely this only happens in 64bit mode and not in 32bit.

In either case it's a bad idea to rely on wine created process having
a parent or not because the wine project may change this anytime.
@notaz
Copy link
Contributor Author

notaz commented Jun 10, 2024

@DomClark @lukas-w ping as git shows you as the authors of PollParentThread.

@zonkmachine zonkmachine requested a review from DomClark June 10, 2024 18:30
@lukas-w
Copy link
Member

lukas-w commented Jun 11, 2024

Sounds like this is the bug described by @PhysSong in the PR that introduced this, see #6366 (comment). There are a few suggestions to work around it in that comment and the following ones, all of which would be preferable to just removing the functionality in the 64bit Wine case as this PR does IMO.

This PR is still better than plain broken VSTs of course, so I won't object to merging it if there are no resources to implement a good solution. PR_SET_CHILD_SUBREAPER should be a 1-line-fix though so maybe give that a try?

@notaz
Copy link
Contributor Author

notaz commented Jun 11, 2024

PR_SET_CHILD_SUBREAPER also works for me so I submitted and alternative PR. Somebody should decide which one is better, as long as 64bit VSTs work it's good enough for me.

@DomClark
Copy link
Member

I agree with @lukas-w that the PR_SET_CHILD_SUBREAPER approach is preferable. I'll close this PR in favour of that one.

@DomClark DomClark closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants