Remove MemoryHelper

[Rossmaxx]

MemoryHelper contains 1 function alignedMalloc which is used in only AudioEngine. Removed the usage and cleaned up the variables previously using the function to use unique pointers.

[Rossmaxx]

I've found out just now that aligned_alloc is missing from windows, that's what is triggering the CI fail.

[DomClark]

I see no reason for these buffers to be aligned in the first place, so I'd simply replace the aligned allocations with normal ones.

In the future, if we want to make an aligned allocation, it would be better to use the aligned versions of operator new and operator delete, which are more idiomatic in C++ code and supported on all platforms. Ideally we would wrap these in a custom allocator, so we can use standard library containers instead of manually allocating arrays on the heap.

[Rossmaxx]

I'd simply replace the aligned allocations with normal ones.

I didn't wanted to introduce any behaviour changes. Also, i have little knowledge on what might break so did the change with minimum cover. If someone wants to refactor, it's completely fine with me. I am just afraid of breaking something unexpected in the process.

If aligning can be removed safely, then it would be better, saving some code and also makes it easier to get into it at a future time. But like i said, something might break somewhere unexpectedly.

[DomClark]

I had a look and I'm fairly sure nothing will break. Do test it yourself, though.

[sakertooth]

You need to also change the type of the variables m_outputBufferRead and m_outputBufferWrite in AudioEngine.h both to std::unique_ptr<surroundSampleFrame[]>.

[Rossmaxx]

I was looking for what caused the error. Thanks for this hint

[sakertooth]

->get should be .get since std::unique_ptr is a class type, not a pointer type.

[Rossmaxx]

->get should be .get since std::unique_ptr is a class type, not a pointer type.

learned that the hard way

[sakertooth]

I recommend compiling your changes to see if they work or not before pushing them.

[sakertooth]

Be sure to test to see if you can start lmms fine now, just in case.

[Rossmaxx]

I can start lmms fine and ran greppi - krem kakkuja and dirtylove projects for 1 - 2 mins each.