-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CI: Run LMMS #7427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CI: Run LMMS #7427
Conversation
|
I tried everything. CI is just ignoring the |
|
Looking at the workflow results, it says that there is an error at the bottom. |
|
Ah, this can be seen only via the Actions tab. Thanks saker! |
8b66270 to
2574f5f
Compare
|
Status: I still need to care about proper downloading of the artifacts. |
eeb80af to
1786b43
Compare
7e8aa57 to
6d286ae
Compare
|
Will merge in 7 days if there are no complaints. |
@JohannesLorenz I know you mentioned on Discord that you were awaiting some help from Dom in regards to testing This leaves use a few options:
|
|
Thanks for offering help.
At least, I can say for sure that branch If there are more complex solutions required to get it run for you, I would rather finish this for Linux and Mac. Like I said, I want to reduce the number of open PRs. A Windows solution can still be delivered later. |
This could be the case. I'm using Prism emulation on ARM. I'll see if it behaves differently on Wintel. |
Nope, no luck. I can get some carla dll errors to show up, but that's about it. Maybe the log handler isn't being registered in time or something. |
Using a local msys2 build, I tried moving the So I feel unless we want to either refactor main.cpp's |
tresf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for macOS and Linux. Windows is sort of left in the dust, explained in more detail here: #7022 (comment)
This runs `lmms --help` in the github CI. Further checks, like importing an LMMS project to WAV via CLI, are conceivable.
1574219 to
884474b
Compare
|
@JohannesLorenz since I haven't received any help over in #7732, I think we'll have to remove Windows from scope of this PR for now. If someone's able to help over on that PR to get a second binary for calling LMMS from console, we can re-add it. |
This runs
lmms --versionandlmms --helpin the github CI. Further checks, like importing an LMMS project to WAV via CLI, are conceivable.Note: This is a split of #6983 . Mutliple reviews have been done there, but one from DomClark is still outstanding, which I am reworking here.
Edit: CI is finally working, but I still need to rework the comments from review -> Keeping this a draft.