Remove the saving midi connection option completely.

[Rossmaxx]

Fixes #3922 I believe.

If not, please guide me to a fix.

[Rossmaxx]

@PhysSong @zonkmachine need some help here

[michaelgregorius]

Now that I have checked #3922 again I am not really sure if this is really the right way to fix the problem that's reported in that issue.

My understanding is that this features enables users to save their MIDI connections in project files so that they can immediately use their MIDI hardware when loading such a file later. If this pull request goes through they'd have to reconnect their devices over and over after each load which would be quite tedious.

The solution to #3922 would be to prevent the storage of MIDI connections when a preset is saved but to keep saving them when a project is being saved.

Edit: I assume that "Don't save MIDI settings." was intended to mean "Don't save MIDI settings when saving presets." in #3922.

[Rossmaxx]

@michaelgregorius your explanation makes sense too, can you tell me which lines to look at if i am to disable the saving for presets instead?

Can someone else clarify michael's assumption?

[michaelgregorius]

@michaelgregorius your explanation makes sense too, can you tell me which lines to look at if i am to disable the saving for presets instead?

Can someone else clarify michael's assumption?

I had started to gather the relevant information for you but then I realized it might be quicker if I simply open a pull request with the things I would have proposed to do. It's pull request #7445.

[Rossmaxx]

Okk. I'll close it in favour of #7445