Fix deadlocks when exporting #7449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A potential infinite wait can happen when closing the FIFO thread if m_stopped is set to true and the device thread never reads the null buffer that signals that the FIFO thread is closing.
3 tasks
Contributor
Author
|
Probably will separate this PR because some of the export fixes may require some larger refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix some bugs with export.
Fixes the "export bomb" bug, where when exporting an empty project, the bug makes it so that the
ProjectRendererthread keeps rendering silence as fast as possible, eliminating the space on the hard drive in seconds.Should fix an export deadlock when exporting an empty project when it reaches 100%
These classes probably need more thorough refactoring though.