Skip to content

Refactor Effect processing #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
messmerd merged 17 commits into from
Sep 21, 2024
Merged

Refactor Effect processing #7484

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a7e8af6
Move common effect processing code to wrapper method
messmerd Sep 2, 2024
51647ff
Fix VstEffect regression
messmerd Sep 2, 2024
67526f0
GranularPitchShifterEffect should not call `checkGate`
messmerd Sep 2, 2024
cf99a6d
Apply suggestions from code review
messmerd Sep 3, 2024
5993030
Follow naming convention for local variables
messmerd Sep 4, 2024
8f77cfa
Add `MAXIMUM_BUFFER_SIZE` and use it in VstEffect
messmerd Sep 4, 2024
f552f7c
Revert "GranularPitchShifterEffect should not call `checkGate`"
messmerd Sep 4, 2024
df58a76
VstEffect: Simplify setting "Don't Run" state
messmerd Sep 9, 2024
a262d17
Rename `sleepImpl` to `processBypassedImpl`
messmerd Sep 9, 2024
0f070e4
Use `MAXIMUM_BUFFER_SIZE` in SetupDialog
messmerd Sep 9, 2024
6efad9b
Pass `outSum` as out parameter; Fix LadspaEffect mutex
messmerd Sep 13, 2024
826b193
Move outSum calculations to wrapper method
messmerd Sep 13, 2024
5dee396
Fix Linux build
messmerd Sep 13, 2024
ef53c0f
Oops
messmerd Sep 13, 2024
5523488
Apply suggestions from code review
messmerd Sep 13, 2024
6f3ec8c
Apply suggestions from code review
messmerd Sep 20, 2024
a165c27
Merge branch 'master' of https://github.com/messmerd/lmms into effect…
messmerd Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use MAXIMUM_BUFFER_SIZE in SetupDialog
  • Loading branch information
@messmerd
messmerd committed Sep 9, 2024
commit 0f070e47ca1840e24695d4512dc1e27d8018d54b
2 changes: 1 addition & 1 deletion src/gui/modals/SetupDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ SetupDialog::SetupDialog(ConfigTab tab_to_open) :
QHBoxLayout * bufferSizeSubLayout = new QHBoxLayout();

m_bufferSizeSlider = new QSlider(Qt::Horizontal, bufferSizeBox);
m_bufferSizeSlider->setRange(1, 128);
m_bufferSizeSlider->setRange(1, MAXIMUM_BUFFER_SIZE / BUFFERSIZE_RESOLUTION);
m_bufferSizeSlider->setTickInterval(8);
m_bufferSizeSlider->setPageStep(8);
m_bufferSizeSlider->setValue(m_bufferSize / BUFFERSIZE_RESOLUTION);
Expand Down