Fix crash on Xpressive when using integrate function
#7499
Conversation
Rossmaxx
changed the title
integrate function
sakertooth
left a comment
sakertooth
left a comment
There was a problem hiding this comment.
Just tested, LGTM. The review below is just about code style.
|
Actually, this is a simple one line fix from what I looked at. If you don't mind, I'll close this one and open my fix. The rest seems to be plain renames. |
|
@gnudles since you didn't reply, I believe you have forgotten about this. I'll give a one week notice and if you don't respond, I'll close this one and take over with my version of the fix. I'll still credit you in the fix. |
|
Please wait with that. Changing types can be dangerous. I do not have too much free time to work on this, but it is better that I will perform the changes |
|
Ok then. |
|
@Rossmaxx thank you for your patience |
gnudles
force-pushed
the
xpressive_bug_fix2
branch
from
10a6e09 to
5a5bd62
Compare
gnudles
force-pushed
the
xpressive_bug_fix2
branch
from
5a5bd62 to
399769b
Compare
|
@sakertooth would you like to merge it? |
sakertooth
left a comment
sakertooth
left a comment
There was a problem hiding this comment.
I'm okay with the changes and the fix (tested it again just now and it seems the crash is gone) 👍
* Fixed a bug in the integrate function, that was caused by warning fixes session. * Xpressive - fixed code style issues.
* Fixed a bug in the integrate function, that was caused by warning fixes session. * Xpressive - fixed code style issues.
4 participants
Fixes: #7468