Partially revert #7453 #7519
Merged
Partially revert #7453 #7519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oops, wrong branch was pushed. |
sakertooth
force-pushed
the
partial-revert-7453
branch
from
f0fdfa1 to
849abd3
Compare
Co-authored-by: Rossmaxx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #7453 to fix regressions. SlicerT remains big and resizable, but most the out of scope changes (i.e., those involving
EffectRackView,EffectView,EnvelopeGraph, etc) were reverted.We should revisit the layout implementation for
InstrumentTrackWindowandSampleTrackWindow. I still think there is a need for a better implementation to make them bigger/resizable. Whatever that entails (layout rework, widget rework, etc) can be discussed when we get around doing that, but for now I am fixing the alarming regressions.