Skip to content

Conversation

@JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Sep 29, 2024

This is a split-of from lv2-ui which consists of many things I had to do to display Lv2 effects properly (and possibly fix other bugs).

This seems to finally be a good PR, but it might still require being extended, see #7510 (comment) .

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Oct 3, 2024

@JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view.

@JohannesLorenz
Copy link
Contributor Author

@JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view.

My PR does not touch effects at all. So what you say may be true (in a trivial way), but does not make my PR wrong or unnecessary.

@JohannesLorenz
Copy link
Contributor Author

JohannesLorenz commented Nov 23, 2024

Open issue: TripleOsc can be resized in this PR. This should not be possible. I have to find out why. Fixed!

@zonkmachine
Copy link
Contributor

This fixes #7510 for me. I haven't tested it extensively and I only reproduced it on a few plugins (caps) but it looks like it's fixed here.

@JohannesLorenz JohannesLorenz mentioned this pull request Feb 2, 2025
21 tasks
@sqrvrt
Copy link
Contributor

sqrvrt commented Feb 11, 2025

Syncing subwindow and embed's sizes seems rather redundant. From my testing just setting QLayout::setFixedSize on embed and moving restrictions from subwindow to embed is enough.

I did basically this in #3532, you could as well test how it works.

@JohannesLorenz
Copy link
Contributor Author

Syncing subwindow and embed's sizes seems rather redundant. From my testing just setting QLayout::setFixedSize on embed and moving restrictions from subwindow to embed is enough.

Imagine a window has a variable width, and the height has a minimum and maximum value. Can you still model such a case?

I did basically this in #3532, you could as well test how it works.

I will close this PR because I think this should be handled in #3532 - that PR likely has more useful test scenarios.

Aside from his, please keep in mind: Since you started to fix an issue in #3532, namely #7510, you should better first have checked that issue for if anyone is working on it - I referenced my PR there in September 2024. Checking issues that we solve can help prevent that two devs work on the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants