-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove the FIFO thread #7568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove the FIFO thread #7568
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
a9b04a4
Remove FIFO thread
sakertooth 378d6b4
Fix selection of frames per period
sakertooth c02c27f
Add "is running" flag for audio devices
sakertooth 1311ce6
Remove extra start/stop flags in audio devices
sakertooth 9d9ca6f
Revert "Remove extra start/stop flags in audio devices"
sakertooth 27272f7
Store separate frames per period size in audio device
sakertooth 5eaff81
Add chunking
sakertooth 07737ce
Fix dummy sound output
sakertooth 72d2882
Specify nullptr explicitly
sakertooth bd52612
Attempt to fix MINGW and MSVC builds
sakertooth 0a130b4
Attempt to fix MINGW and MSVC builds
sakertooth 7fb14b7
Pass in size parameter to getNextBuffer, return bool instead
sakertooth b84bec1
Remove processNextBuffer and move writeBuffer into AudioDevice
sakertooth aeb5fdf
Create AudioDevice::nextBuffer function to simplify translation of re…
sakertooth c8ef1a6
Fix nextBuffer function
sakertooth 3dd62ee
Calculate the number of frames based on the length parameter in sdlAu…
sakertooth 7ebb85a
Use SND_PCM_FORMAT_FLOAT in ALSA
sakertooth 6597ce3
Remove assert
sakertooth cfd51c1
Fix comparison warnings
sakertooth f414cf5
Pass in correct frame count when fetching buffers in PortAudio callback
sakertooth 8e5cede
Use PA_SAMPLE_FLOAT32 in PulseAudio
sakertooth a7d5e4b
Use pa_stream_begin_write to avoid extra copies
sakertooth f5dc315
Fix soundio callback
sakertooth f5d0e4c
Do not ignore return type on write call in OSS
sakertooth d562fe9
Ensure to silence buffer if nextBuffer returns false for callback-bas…
sakertooth 10c55da
Use same signedness
sakertooth b5bfa07
Fix more signedness issues
sakertooth bc0abb7
Fix a few issues
sakertooth f23122b
Split nextBuffer declaration into two (one for interleaved, one for p…
sakertooth 4d1e182
Update src/core/audio/AudioAlsa.cpp
sakertooth 821189e
Use static_cast instead of reinterpret_cast
sakertooth ce20d72
Use new audio buffer view classes
sakertooth abd51d6
Render next buffer after resetting timer
sakertooth ee70d3f
Remove endian handling within audio devices
sakertooth 243f299
Make start and stop functions non-virtual, add pure virtual impl func…
sakertooth 8ffa18a
Make startProcessing and stopProcessing non virtual
sakertooth 0dd7795
Remove unused function that was added in here
sakertooth 717e49f
Remove temp
sakertooth 9a7fc69
Add isRunning function
sakertooth 5bdff28
Merge remote-tracking branch 'upstream' into fix-resampling
sakertooth a7df657
Fix build
sakertooth 1eb4ef4
Merge remote-tracking branch 'upstream' into revamp-buffers
sakertooth 195b823
Simplify nextBuffer function with new AudioBufferView concept
sakertooth f8995b7
Simplify loop even further
sakertooth 4d0d8fe
Check if device running in while loop
sakertooth 05f41b2
Remove m_quit variable
sakertooth cd63c6a
Add sample function in buffer view classes
sakertooth 5f71b0b
Remove framesPerPeriod from AudioDevice
sakertooth af53322
Set the buffer size for the JACK backend
sakertooth 872baef
Use framesPerAudioBuffer where appropriate
sakertooth 26ba7ad
Move template instantiations down the file
sakertooth c1857a2
Do not call stopProcessing in destructor, assert that device is stopp…
sakertooth 6c97be8
Merge remote-tracking branch 'upstream' into revamp-buffers
sakertooth e00f57f
Set frames per audio buffer within engine
sakertooth 4a17480
Add new renderNextPeriod function, move use of nextBuffer to renderNe…
sakertooth bea72f8
Change assert
sakertooth 6bf8707
Merge remote-tracking branch 'upstream' into revamp-buffers
sakertooth d460b5f
Fix build
sakertooth 927141b
Force period size to DEFAULT_BUFFER_SIZE
sakertooth a04d74d
Use AudioBufferView again
sakertooth 6c469fc
Update documentation
sakertooth 1149cd0
Remove unused variables in SDL device
sakertooth 3bb7b29
Split renderNextBuffer into two overloads
sakertooth 561d0de
Revert "Force period size to DEFAULT_BUFFER_SIZE"
sakertooth ffea3d9
Update documenation
sakertooth e01046f
Switch fpp_t and f_cnt_t to std::uint64_t
sakertooth 2bfa6c6
Move frameCount calculation down
sakertooth c1ddc3e
Cast frames per audio buffer to fpp_t
sakertooth f2e3b30
Revert "Switch fpp_t and f_cnt_t to std::uint64_t"
sakertooth de354de
Merge remote-tracking branch 'upstream' into revamp-buffers
sakertooth 7da9cfc
Merge remote-tracking branch 'upstream' into revamp-buffers
sakertooth 2a266ff
Change type of frame count in AudioFileDevice::writeBuffer
sakertooth febfbe6
Inline bufferView
sakertooth 8569d4a
Revert changes to AudioFileMP3.h
sakertooth 8e181f8
Remove extra whitespace
sakertooth 7f5b543
Remove m_devMutex and move header include of AudioBufferView.h
sakertooth bbee641
Remove DEFAULT_SAMPLE_RATE
sakertooth b09cc43
Use AudioBufferView again, use one implementation and make it private
sakertooth c70d4e9
Fix misspelling in documentation
sakertooth e77c2c5
Remove redundant std::array::fill call
sakertooth 49f8d1c
Use static_cast instead of reinterpret_cast
sakertooth 26c9e94
Return early if pa_stream_begin_write returns a nonzero value
sakertooth a38ad83
Remove iostream include
sakertooth 8cf7c4e
Update documentation
sakertooth 3b10d33
Do not set JACK buffer size
sakertooth 78ee349
Fix some bugs with AudioJack, add input processing back in
sakertooth 2af783e
Mention possibility of removing framesPerAudioBuffer in a later refactor
sakertooth c2ccbfd
Fix spelling in docs
sakertooth 3da74c0
Simplify wording in docs
sakertooth 57b8bed
Remove outBuf from AudioPortAudio
sakertooth 2bd6411
Fix unused lambda capture warning
sakertooth e339682
Comma ftw
sakertooth 7c7e37f
Change renderNextPeriod to return a span
sakertooth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Attempt to fix MINGW and MSVC builds
- Loading branch information
commit bd526124981a8b0ccc20571367def50a9252ceeb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.