Update macOS CI #7572
Merged
Update macOS CI #7572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XCode 15.2 is the default on macOS 13
Cannot format `const void*` as a string
JohannesLorenz
approved these changes
Nov 6, 2024
Contributor
JohannesLorenz
left a comment
JohannesLorenz
left a comment
There was a problem hiding this comment.
Approved:
- Functional review OK ✔️
- Style review OK ✔️
- Test review OK ✔️
IMO, no 2nd review is required here.
messmerd
added
macos
CI
rubiefawn
pushed a commit
to rubiefawn/lmms
that referenced
this pull request
Nov 28, 2024
* Use macOS 13 See: actions/runner-images#10721 * Upgrade to XCode 15.2 XCode 15.2 is the default on macOS 13 * Fix unqualified call to std::move warning * Fix sprintf deprecated warnings * Upgrade macOS 14 ARM64 builds to XCode 15.4 See: actions/runner-images#10703 * Fix unused lambda capture warnings in Fader.cpp * Fix unused variable warnings * Fix formatting warning Cannot format `const void*` as a string * Force lambda conversion to function pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub is removing the macOS 12 build runners on December 3, and is removing XCode 14 and 16 from macOS 14 on November 4 (today!).
This PR:
sprintfdeprecation warnings coming from 3rd party libraries, but all usages ofsprintfin LMMS itself have been converted tostd::snprintf