Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
872409a
Use dbFS scale for the faders
michaelgregorius Apr 5, 2024
f8e0bf5
Apply curve to faders
michaelgregorius Dec 23, 2024
def44ae
Support for dB models
michaelgregorius Dec 24, 2024
be0084b
Show current dB value of fader in tool tip
michaelgregorius Dec 24, 2024
a6dbdc0
Let users enter values in dB
michaelgregorius Dec 24, 2024
14c3c97
Remove option "Display volume as dBFS"
michaelgregorius Dec 24, 2024
3510dea
Extend Fader::wheelEvent
michaelgregorius Dec 24, 2024
1f9f96d
Adjust the wheel behavior for faders with dB models
michaelgregorius Dec 24, 2024
a86ca84
Less "jumpy" knobs
michaelgregorius Dec 27, 2024
71c0ed7
Make MSVC happy
michaelgregorius Dec 27, 2024
795c681
Introduce constexpr for scaling exponent
michaelgregorius Dec 29, 2024
344fae2
Draw fader ticks
michaelgregorius Dec 29, 2024
aa74df2
Fader adjustments via keyboard
michaelgregorius Dec 29, 2024
4a720cb
Move the fader of the selected channel
michaelgregorius Jan 12, 2025
d451531
Enter fader value when space key pressed
michaelgregorius Jan 12, 2025
fa9148e
Merge remote-tracking branch 'upstream/master' into FadersWithDbScale
michaelgregorius Jan 12, 2025
8f0d877
More prominent fader ticks around 0 dB
michaelgregorius Feb 1, 2025
ff435d5
Work around a Qt bug
michaelgregorius Feb 1, 2025
5a66348
Fix wheel events without any modifier
michaelgregorius Feb 1, 2025
8d5c523
Code review changes
michaelgregorius Feb 8, 2025
ccae1b5
Make minimum dB value a constexpr
michaelgregorius Feb 8, 2025
f02c464
More flexible painting of fader ticks
michaelgregorius Feb 8, 2025
41598a9
Make the zero indicator bolder
michaelgregorius Feb 8, 2025
57ad0e6
Make rendering of fader ticks a preference
michaelgregorius Feb 8, 2025
74d33a6
Move constexprs to anonymous namespace
michaelgregorius Feb 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More prominent fader ticks around 0 dB
Make the fader ticks around 0 dB more prominent but drawing them
slightly wider and with a more opaque color.
  • Loading branch information
michaelgregorius committed Feb 1, 2025
commit 8f0d877251f001f2acd9075aff4a3b29a980b151
12 changes: 11 additions & 1 deletion src/gui/widgets/Fader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -697,13 +697,23 @@ void Fader::paintFaderTicks(QPainter& painter)
{
painter.save();

painter.setPen(QColor(255, 255, 255, 128));
const QPen zeroPen(QColor(255, 255, 255, 216), 1.5);
const QPen nonZeroPen(QColor(255, 255, 255, 128), 1.);

for (float i = 6.f; i >= -120.f; i-= 6.f)
Comment thread
sakertooth marked this conversation as resolved.
Outdated
{
const auto scaledRatio = computeScaledRatio(i);
const auto maxHeight = height() - (height() - m_knob.height()) * scaledRatio - (m_knob.height() / 2);

if (approximatelyEqual(i, 0.))
{
painter.setPen(zeroPen);
}
else
{
painter.setPen(nonZeroPen);
}

painter.drawLine(QPointF(0, maxHeight), QPointF(1, maxHeight));
painter.drawLine(QPointF(width() - 1, maxHeight), QPointF(width(), maxHeight));
}
Expand Down