Skip to content

[Follow up] Improve performance when rendering sample waveforms #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sakertooth merged 14 commits into from
Apr 16, 2025
Merged

[Follow up] Improve performance when rendering sample waveforms #7695

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1225b0e
Rebase to master; Attemp to fix garbage rendering on large samples; F…
khoidauminh Feb 9, 2025
d6b026f
Use sample.buffer()->data()->data()
khoidauminh Feb 9, 2025
382de8f
Use infinity and -infinity as the default minimum and maximum values …
sakertooth Feb 10, 2025
564914f
Simplify type conversions
sakertooth Feb 10, 2025
cc2c91f
Directly use original buffer when necessary
sakertooth Feb 11, 2025
c446cf6
Minimize scope
sakertooth Feb 11, 2025
bf000e3
Repaint clips of track on removal
khoidauminh Feb 17, 2025
7639dbf
Fix shifting when moving an overlay on the clip(?) Don't draw borders…
khoidauminh Feb 17, 2025
cc47d9a
Avoid dereferencing the thumbnail when not needed
khoidauminh Feb 18, 2025
e96e1e6
Use continue
khoidauminh Feb 19, 2025
b58c719
Update src/gui/clips/SampleClipView.cpp
sakertooth Mar 2, 2025
68d86bb
Clamp beginIndex and endIndex to the bounds of the array
sakertooth Mar 23, 2025
0441eba
Fix incorrect rendering when overlay is moved away from sampleclip be…
khoidauminh Mar 25, 2025
f6eafdc
Fix incorrect rendering with overlays for Automation Editor
khoidauminh Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/gui/clips/SampleClipView.cpp
  • Loading branch information
@sakertooth
sakertooth authored Mar 2, 2025
commit b58c7199327d3b0b2fd1cee2bdc461e2ca7e9bf3
2 changes: 1 addition & 1 deletion src/gui/clips/SampleClipView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ void SampleClipView::paintEvent( QPaintEvent * pe )

// outer border
p.setPen( c.darker( 200 ) );
p.drawRect( -m_paintPixmapXPosition, 0, rect().right(), rect().bottom() );
p.drawRect(-m_paintPixmapXPosition, 0, rect().right(), rect().bottom());

// draw the 'muted' pixmap only if the clip was manualy muted
if( m_clip->isMuted() )
Expand Down
Loading